Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve MaxPieceSize when calling SetAsk #438

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Preserve MaxPieceSize when calling SetAsk #438

merged 1 commit into from
Oct 19, 2020

Conversation

ingar
Copy link
Contributor

@ingar ingar commented Oct 19, 2020

Problem

If SetAsk() is called without a parameter to configure MaxPieceSize, it will revert to the default value.

Solution

If a previously-stored ask is available, use its MaxPieceSize as a default, like is done for MinPieceSize

@ingar ingar mentioned this pull request Oct 19, 2020
Merged
hannahhoward
hannahhoward approved these changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannahhoward hannahhoward merged commit 4566e39 into master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahhoward hannahhoward hannahhoward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ingar @hannahhoward