Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't overwrite previously-configured maxPieceSize for a persisted ask #4480

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Don't overwrite previously-configured maxPieceSize for a persisted ask #4480

merged 1 commit into from
Oct 19, 2020

Conversation

ingar
Copy link
Contributor

@ingar ingar commented Oct 19, 2020 •
edited
Loading

Problem

When constructing a new stored ask, the MaxPieceSize was not properly preserved.

Solution

There was leftover code that was inadvertently overwriting the provided MaxPieceSize with the default.

Related: filecoin-project/go-fil-markets#438

Resolves #4440, #4458

@magik6k magik6k merged commit 06c0444 into master Oct 19, 2020
@magik6k magik6k deleted the fix/max-piece-size-reverting-to-default branch October 19, 2020 20:55
@pooja pooja mentioned this pull request Oct 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lotus-miner storage-deals not holding Max Piece Size
2 participants
@ingar @magik6k