fix extend v1 sector #6033
Closed
fix extend v1 sector #6033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TerenceClark
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
3 tasks
3 tasks
arajasek
approved these changes
Jul 11, 2021
| @@ -507,6 +507,9 @@ var sectorsExtendCmd = &cli.Command{ | |||
|
|
|||
| // Set the new expiration to 48 hours less than the theoretical maximum lifetime | |||
| newExp := ml - (miner3.WPoStProvingPeriod * 2) + si.Activation | |||
| if withinTolerance(si.Expiration, newExp) { | |||
There was a problem hiding this comment.
This is somewhat redundant due to the check on line 504, but happy to allow it.
| @@ -524,7 +527,8 @@ var sectorsExtendCmd = &cli.Command{ | |||
| } else { | |||
| added := false | |||
| for exp := range es { | |||
| if withinTolerance(exp, newExp) { | |||
| // newExp < exp, can't extend | |||
| if withinTolerance(exp, newExp) && newExp >= exp { | |||
There was a problem hiding this comment.
Nice catch, thank you! The optimal thing to do would be to repack the extensions, replacing exp with the smaller newExp in this case, but I don't think it's too important.
|
Closing in favour of #6066 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.