Fix bugs in sectors extend --v1-sectors #6066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadwick2143
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
|
this could address #6180 too |
arajasek
suggested changes
Jul 11, 2021
| @@ -507,6 +517,10 @@ var sectorsExtendCmd = &cli.Command{ | |||
|
|
|||
| // Set the new expiration to 48 hours less than the theoretical maximum lifetime | |||
| newExp := ml - (miner3.WPoStProvingPeriod * 2) + si.Activation | |||
| if withinTolerance(si.Expiration, newExp) || si.Expiration >= newExp { | |||
There was a problem hiding this comment.
Both of these should be redundant thanks to the check in line 514, but no reason to omit.
| @@ -435,6 +435,12 @@ var sectorsExtendCmd = &cli.Command{ | |||
| Usage: "when extending v1 sectors, don't try to extend sectors by fewer than this number of epochs", | |||
| Required: false, | |||
| }, | |||
| &cli.Int64Flag{ | |||
| Name: "expiration-ignore", | |||
| Value: 120, | |||
There was a problem hiding this comment.
I'd suggest a larger default than 2 hours, but users need to be specifying this.
arajasek
approved these changes
Jul 11, 2021
Closed
It doesn't address it, but the solution to 6180 will share similar logic to the v1 sector extension logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bugs described in #6027
Based on the work of #6033