feat!: migrate firebase_remote_config nullsafety

packages/firebase_remote_config/firebase_remote_config/lib/firebase_remote_config.dart

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// @dart=2.9
-
 library firebase_remote_config;
 
 import 'dart:async';

packages/firebase_remote_config/firebase_remote_config/lib/src/remote_config.dart

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// @dart=2.9
-
 part of firebase_remote_config;
 
 /// The entry point for accessing Remote Config.
@@ -12,7 +10,7 @@ part of firebase_remote_config;
 /// [RemoteConfig.instance] is async.
 // ignore: prefer_mixin
 class RemoteConfig extends FirebasePluginPlatform with ChangeNotifier {
-  RemoteConfig._({this.app})
+  RemoteConfig._({required this.app})
       : super(app.name, 'plugins.flutter.io/firebase_remote_config');
 
   // Cached instances of [FirebaseRemoteConfig].
@@ -22,18 +20,18 @@ class RemoteConfig extends FirebasePluginPlatform with ChangeNotifier {
   // to avoid creating a [MethodChannelFirebaseRemoteConfig] when not needed
   // or creating an instance with the default app before a user specifies an
   // app.
-  FirebaseRemoteConfigPlatform _delegatePackingProperty;
+  late final FirebaseRemoteConfigPlatform _delegatePackingProperty =
+      FirebaseRemoteConfigPlatform.instanceFor(
+    app: app,
+    pluginConstants: pluginConstants,
+  );
 
   /// Returns the underlying delegate implementation.
   ///
   /// If called and no [_delegatePackingProperty] exists, it will first be
   /// created and assigned before returning the delegate.
   FirebaseRemoteConfigPlatform get _delegate {
-    return _delegatePackingProperty ??=
-        FirebaseRemoteConfigPlatform.instanceFor(
-      app: app,
-      pluginConstants: pluginConstants,
-    );
+    return _delegatePackingProperty;
   }
 
   /// The [FirebaseApp] this instance was initialized with.
@@ -45,11 +43,9 @@ class RemoteConfig extends FirebasePluginPlatform with ChangeNotifier {
   }
 
   /// Returns an instance using the specified [FirebaseApp].
-  static RemoteConfig instanceFor({@required FirebaseApp app}) {
-    assert(app != null);
-
+  static RemoteConfig instanceFor({required FirebaseApp app}) {
     if (_firebaseRemoteConfigInstances.containsKey(app.name)) {
-      return _firebaseRemoteConfigInstances[app.name];
+      return _firebaseRemoteConfigInstances[app.name]!;
     }
 
     RemoteConfig newInstance = RemoteConfig._(app: app);
@@ -63,17 +59,17 @@ class RemoteConfig extends FirebasePluginPlatform with ChangeNotifier {
   /// If no successful fetch has been made a [DateTime] representing
   /// the epoch (1970-01-01 UTC) is returned.
   DateTime get lastFetchTime {
-    return _delegate.lastFetchTime;
+    return _delegate.lastFetchTime!;
   }
 
   /// Returns the status of the last fetch attempt.
   RemoteConfigFetchStatus get lastFetchStatus {
-    return _delegate.lastFetchStatus;
+    return _delegate.lastFetchStatus!;
   }
 
   /// Returns the [RemoteConfigSettings] of the current instance.
   RemoteConfigSettings get settings {
-    return _delegate.settings;
+    return _delegate.settings!;
   }
 
   /// Makes the last fetched config available to getters.
@@ -113,39 +109,31 @@ class RemoteConfig extends FirebasePluginPlatform with ChangeNotifier {
 
   /// Gets the value for a given key as a bool.
   bool getBool(String key) {
-    assert(key != null);
     return _delegate.getBool(key);
   }
 
   /// Gets the value for a given key as an int.
   int getInt(String key) {
-    assert(key != null);
     return _delegate.getInt(key);
   }
 
   /// Gets the value for a given key as a double.
   double getDouble(String key) {
-    assert(key != null);
     return _delegate.getDouble(key);
   }
 
   /// Gets the value for a given key as a String.
   String getString(String key) {
-    assert(key != null);
     return _delegate.getString(key);
   }
 
   /// Gets the [RemoteConfigValue] for a given key.
   RemoteConfigValue getValue(String key) {
-    assert(key != null);
     return _delegate.getValue(key);
   }
 
   /// Sets the [RemoteConfigSettings] for the current instance.
   Future<void> setConfigSettings(RemoteConfigSettings remoteConfigSettings) {
-    assert(remoteConfigSettings != null);
-    assert(remoteConfigSettings.fetchTimeout != null);
-    assert(remoteConfigSettings.minimumFetchInterval != null);
     assert(!remoteConfigSettings.fetchTimeout.isNegative);
     assert(!remoteConfigSettings.minimumFetchInterval.isNegative);
     // To be consistent with iOS fetchTimeout is set to the default
@@ -158,7 +146,6 @@ class RemoteConfig extends FirebasePluginPlatform with ChangeNotifier {
 
   /// Sets the default parameter values for the current instance.
   Future<void> setDefaults(Map<String, dynamic> defaultParameters) {
-    assert(defaultParameters != null);
     return _delegate.setDefaults(defaultParameters);
   }
 }