-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: migrate firebase_remote_config nullsafety #5397
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks! Could you fix the lint errors? https://github.com/FirebaseExtended/flutterfire/pull/5397/checks?check_run_id=2148189173 |
I think the Analytics portion of this PR may be a duplicate of the work being done on #5341 - can we perhaps remove it from this PR and focus on just Remote Config here? Thoughts @rrousselGit? |
@Salakar @rrousselGit also in this PR are the same issues that @rrousselGit mentioned that I already fixed in my PR :) |
packages/firebase_remote_config/firebase_remote_config/lib/src/remote_config.dart
Show resolved
Hide resolved
..._config_platform_interface/lib/src/method_channel/method_channel_firebase_remote_config.dart
Outdated
Show resolved
Hide resolved
Let's focus on Remote config for this PR - @daniloadorno would you mind removing the analytics portions of this pull request - thanks. |
@daniloadorno I saw you worked on the migration. Is it ready ? |
yes |
Could you format and fix the test step? |
done |
...platform_interface/lib/src/platform_interface/platform_interface_firebase_remote_config.dart
Outdated
Show resolved
Hide resolved
..._config_platform_interface/lib/src/method_channel/method_channel_firebase_remote_config.dart
Outdated
Show resolved
Hide resolved
await remoteConfig.fetchAndActivate(); | ||
expect(remoteConfig.lastFetchStatus, RemoteConfigFetchStatus.success); | ||
//await remoteConfig.fetchAndActivate(); | ||
/*expect(remoteConfig.lastFetchStatus, RemoteConfigFetchStatus.success); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these tests commented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they refer to the old implementation without nullsafety and have errors in their execution
packages/firebase_remote_config/firebase_remote_config/lib/src/remote_config.dart
Outdated
Show resolved
Hide resolved
packages/firebase_remote_config/firebase_remote_config/lib/src/remote_config.dart
Outdated
Show resolved
Hide resolved
packages/firebase_remote_config/firebase_remote_config/lib/src/remote_config.dart
Outdated
Show resolved
Hide resolved
packages/firebase_remote_config/firebase_remote_config/lib/src/remote_config.dart
Outdated
Show resolved
Hide resolved
packages/firebase_remote_config/firebase_remote_config/test/firebase_remote_config_test.dart
Show resolved
Hide resolved
..._config_platform_interface/lib/src/method_channel/method_channel_firebase_remote_config.dart
Outdated
Show resolved
Hide resolved
..._config_platform_interface/lib/src/method_channel/method_channel_firebase_remote_config.dart
Outdated
Show resolved
Hide resolved
..._config_platform_interface/lib/src/method_channel/method_channel_firebase_remote_config.dart
Outdated
Show resolved
Hide resolved
..._config_platform_interface/lib/src/method_channel/method_channel_firebase_remote_config.dart
Outdated
Show resolved
Hide resolved
...platform_interface/lib/src/platform_interface/platform_interface_firebase_remote_config.dart
Outdated
Show resolved
Hide resolved
...platform_interface/lib/src/platform_interface/platform_interface_firebase_remote_config.dart
Outdated
Show resolved
Hide resolved
...platform_interface/lib/src/platform_interface/platform_interface_firebase_remote_config.dart
Outdated
Show resolved
Hide resolved
...platform_interface/lib/src/platform_interface/platform_interface_firebase_remote_config.dart
Outdated
Show resolved
Hide resolved
...platform_interface/lib/src/platform_interface/platform_interface_firebase_remote_config.dart
Outdated
Show resolved
Hide resolved
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@rrousselGit I believe there's a problem with @daniloadorno's commits. It seems like he commited changes with an alter account not related to GitHub and the Google checks are not passing. Any thoughts? |
No description provided.