feat(firebase_remote_config)!: migrate to nullsafety

packages/firebase_remote_config/firebase_remote_config/example/android/app/src/main/java/io/flutter/plugins/firebase/firebaseremoteconfigexample/EmbeddingV1Activity.java

@@ -5,7 +5,6 @@
 package io.flutter.plugins.firebase.firebaseremoteconfigexample;
 
 import android.os.Bundle;
-import dev.flutter.plugins.e2e.E2EPlugin;
 import io.flutter.app.FlutterActivity;
 import io.flutter.plugins.firebase.core.FlutterFirebaseCorePlugin;
 import io.flutter.plugins.firebase.firebaseremoteconfig.FirebaseRemoteConfigPlugin;
@@ -19,6 +18,5 @@ protected void onCreate(Bundle savedInstanceState) {
     FirebaseRemoteConfigPlugin.registerWith(
         registrarFor(
             "io.flutter.plugins.firebase.firebaseremoteconfig.FirebaseRemoteConfigPlugin"));
-    E2EPlugin.registerWith(registrarFor("dev.flutter.plugins.e2e.E2EPlugin"));
   }
 }

packages/firebase_remote_config/firebase_remote_config/example/lib/main.dart

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// @dart=2.9
-
 import 'dart:async';
 
 import 'package:firebase_core/firebase_core.dart';
@@ -19,14 +17,16 @@ void main() {
         future: setupRemoteConfig(),
         builder: (BuildContext context, AsyncSnapshot<RemoteConfig> snapshot) {
           return snapshot.hasData
-              ? WelcomeWidget(remoteConfig: snapshot.data)
+              ? WelcomeWidget(remoteConfig: snapshot.requireData)
               : Container();
         },
       )));
 }
 
 class WelcomeWidget extends AnimatedWidget {
-  WelcomeWidget({this.remoteConfig}) : super(listenable: remoteConfig);
+  WelcomeWidget({
+    required this.remoteConfig,
+  }) : super(listenable: remoteConfig);
 
   final RemoteConfig remoteConfig;
 

packages/firebase_remote_config/firebase_remote_config/example/pubspec.yaml

@@ -27,13 +27,14 @@ dependency_overrides:
     path: ../../firebase_remote_config_platform_interface
 
 dev_dependencies:
-  pedantic: ^1.8.0
+  integration_test:
+    sdk: flutter
   flutter_test:
     sdk: flutter
   flutter_driver:
     sdk: flutter
+  pedantic: ^1.8.0
   test: any
-  e2e: ^0.6.1
 
 flutter:
   uses-material-design: true

packages/firebase_remote_config/firebase_remote_config/example/test_driver/firebase_remote_config_e2e.dart

@@ -1,15 +1,13 @@
-// @dart=2.9
-
 import 'package:flutter_test/flutter_test.dart';
-import 'package:e2e/e2e.dart';
+import 'package:integration_test/integration_test.dart';
 import 'package:firebase_core/firebase_core.dart';
 import 'package:firebase_remote_config/firebase_remote_config.dart';
 
 void main() {
-  E2EWidgetsFlutterBinding.ensureInitialized();
+  IntegrationTestWidgetsFlutterBinding.ensureInitialized();
 
   group('$RemoteConfig', () {
-    RemoteConfig remoteConfig;
+    late RemoteConfig remoteConfig;
 
     setUp(() async {
       await Firebase.initializeApp();

packages/firebase_remote_config/firebase_remote_config/example/test_driver/firebase_remote_config_e2e_test.dart

@@ -2,8 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// @dart=2.9
+import 'package:integration_test/integration_test_driver.dart';
 
-import 'package:e2e/e2e_driver.dart' as e2e;
-
-void main() => e2e.main();
+Future<void> main() => integrationDriver();

packages/firebase_remote_config/firebase_remote_config/ios/Classes/FLTFirebaseRemoteConfigPlugin.m

@@ -163,7 +163,11 @@ - (void)fetchAndActivate:(id)arguments withMethodCallResult:(FLTFirebaseMethodCa
     if (error != nil) {
       result.error(nil, nil, nil, error);
     } else {
-      result.success(nil);
+      if (status == FIRRemoteConfigFetchAndActivateStatusSuccessFetchedFromRemote) {
+        result.success(@(YES));
+      } else {
+        result.success(@(NO));
+      }
     }
   }];
 }

packages/firebase_remote_config/firebase_remote_config/lib/firebase_remote_config.dart

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// @dart=2.9
-
 library firebase_remote_config;
 
 import 'dart:async';

packages/firebase_remote_config/firebase_remote_config/lib/src/remote_config.dart

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// @dart=2.9
-
 part of firebase_remote_config;
 
 /// The entry point for accessing Remote Config.
@@ -12,29 +10,20 @@ part of firebase_remote_config;
 /// [RemoteConfig.instance] is async.
 // ignore: prefer_mixin
 class RemoteConfig extends FirebasePluginPlatform with ChangeNotifier {
-  RemoteConfig._({this.app})
+  RemoteConfig._({required this.app})
       : super(app.name, 'plugins.flutter.io/firebase_remote_config');
 
   // Cached instances of [FirebaseRemoteConfig].
   static final Map<String, RemoteConfig> _firebaseRemoteConfigInstances = {};
 
-  // Cached and lazily loaded instance of [FirebaseRemoteConfigPlatform]
-  // to avoid creating a [MethodChannelFirebaseRemoteConfig] when not needed
-  // or creating an instance with the default app before a user specifies an
-  // app.
-  FirebaseRemoteConfigPlatform _delegatePackingProperty;
-
   /// Returns the underlying delegate implementation.
   ///
   /// If called and no [_delegatePackingProperty] exists, it will first be
   /// created and assigned before returning the delegate.
-  FirebaseRemoteConfigPlatform get _delegate {
-    return _delegatePackingProperty ??=
-        FirebaseRemoteConfigPlatform.instanceFor(
-      app: app,
-      pluginConstants: pluginConstants,
-    );
-  }
+  late final _delegate = FirebaseRemoteConfigPlatform.instanceFor(
+    app: app,
+    pluginConstants: pluginConstants,
+  );
 
   /// The [FirebaseApp] this instance was initialized with.
   final FirebaseApp app;
@@ -45,17 +34,10 @@ class RemoteConfig extends FirebasePluginPlatform with ChangeNotifier {
   }
 
   /// Returns an instance using the specified [FirebaseApp].
-  static RemoteConfig instanceFor({@required FirebaseApp app}) {
-    assert(app != null);
-
-    if (_firebaseRemoteConfigInstances.containsKey(app.name)) {
-      return _firebaseRemoteConfigInstances[app.name];
-    }
-
-    RemoteConfig newInstance = RemoteConfig._(app: app);
-    _firebaseRemoteConfigInstances[app.name] = newInstance;
-
-    return newInstance;
+  static RemoteConfig instanceFor({required FirebaseApp app}) {
+    return _firebaseRemoteConfigInstances.putIfAbsent(app.name, () {
+      return RemoteConfig._(app: app);
+    });
   }
 
   /// Returns the [DateTime] of the last successful fetch.
@@ -113,39 +95,31 @@ class RemoteConfig extends FirebasePluginPlatform with ChangeNotifier {
 
   /// Gets the value for a given key as a bool.
   bool getBool(String key) {
-    assert(key != null);
     return _delegate.getBool(key);
   }
 
   /// Gets the value for a given key as an int.
   int getInt(String key) {
-    assert(key != null);
     return _delegate.getInt(key);
   }
 
   /// Gets the value for a given key as a double.
   double getDouble(String key) {
-    assert(key != null);
     return _delegate.getDouble(key);
   }
 
   /// Gets the value for a given key as a String.
   String getString(String key) {
-    assert(key != null);
     return _delegate.getString(key);
   }
 
   /// Gets the [RemoteConfigValue] for a given key.
   RemoteConfigValue getValue(String key) {
-    assert(key != null);
     return _delegate.getValue(key);
   }
 
   /// Sets the [RemoteConfigSettings] for the current instance.
   Future<void> setConfigSettings(RemoteConfigSettings remoteConfigSettings) {
-    assert(remoteConfigSettings != null);
-    assert(remoteConfigSettings.fetchTimeout != null);
-    assert(remoteConfigSettings.minimumFetchInterval != null);
     assert(!remoteConfigSettings.fetchTimeout.isNegative);
     assert(!remoteConfigSettings.minimumFetchInterval.isNegative);
     // To be consistent with iOS fetchTimeout is set to the default
@@ -158,7 +132,6 @@ class RemoteConfig extends FirebasePluginPlatform with ChangeNotifier {
 
   /// Sets the default parameter values for the current instance.
   Future<void> setDefaults(Map<String, dynamic> defaultParameters) {
-    assert(defaultParameters != null);
     return _delegate.setDefaults(defaultParameters);
   }
 }