Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firebase_remote_config)!: migrate to nullsafety #5686

Merged
merged 9 commits into from
Apr 14, 2021

Conversation

daniloadorno
Copy link
Contributor

@daniloadorno daniloadorno commented Apr 7, 2021

Replacement for #5397

@google-cla google-cla bot added the cla: yes label Apr 7, 2021
@Zeswen
Copy link

Zeswen commented Apr 7, 2021

Looking forward to it :)

@Ehesp Ehesp changed the title feat !: migrate firebase_remote_config nullsafety feat(firebase_remote_config)!: migrate to nullsafety Apr 7, 2021
@Salakar Salakar requested a review from rrousselGit April 7, 2021 13:12
@rrousselGit rrousselGit self-assigned this Apr 7, 2021
@google-cla
Copy link

google-cla bot commented Apr 7, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Apr 7, 2021
@rrousselGit
Copy link
Contributor

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 7, 2021
@TheJulianJES
Copy link

TheJulianJES commented Apr 7, 2021

Getting the following error:

flutter: Null check operator used on a null value
flutter: #0      convertPlatformException (package:firebase_remote_config_platform_interface/src/method_channel/utils/exception.dart:9:5)
#1      MethodChannelFirebaseRemoteConfig.fetchAndActivate (package:firebase_remote_config_platform_interface/src/method_channel/method_channel_firebase_remote_config.dart:155:13)
<asynchronous suspension>
#2      RemoteConfig.fetchAndActivate (package:firebase_remote_config/src/remote_config.dart:86:26)
<asynchronous suspension>

Edit: Same reason for the build failing: https://github.com/FirebaseExtended/flutterfire/pull/5686/checks?check_run_id=2288832143#step:6:265

@b-jan
Copy link

b-jan commented Apr 12, 2021

Hello, is it ready? Can you merge it?

@rrousselGit
Copy link
Contributor

We have some failing tests that needs to be fixed

@b-jan
Copy link

b-jan commented Apr 12, 2021

@rrousselGit How much time do you need? Can I help?

@google-cla
Copy link

google-cla bot commented Apr 13, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Apr 13, 2021
@russellwheatley
Copy link
Member

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 13, 2021
@Zeswen
Copy link

Zeswen commented Apr 14, 2021

@rrousselGit waiting for your review!

Everyone nice work with the update, thank you so much for your contributions!

@Salakar Salakar merged commit 457eba1 into firebase:master Apr 14, 2021
@Zeswen
Copy link

Zeswen commented Apr 14, 2021

Are you going to make the release today? Or are you waiting on other fixes?

@TheJulianJES
Copy link

TheJulianJES commented Apr 14, 2021

You can always use something like this in the meantime:

dependencies:
  # ...
  firebase_remote_config:
    git:
      url: git://github.com/FirebaseExtended/flutterfire
      ref: master
      path: packages/firebase_remote_config/firebase_remote_config
dependency_overrides:
  firebase_remote_config_platform_interface:
    git:
      url: git://github.com/FirebaseExtended/flutterfire
      ref: master
      path: packages/firebase_remote_config/firebase_remote_config_platform_interface

Edit: I do get an exception on macOS. iOS seems to work fine

@Salakar
Copy link
Member

Salakar commented Apr 14, 2021

This has now been published to pub.dev as 0.10.0-dev.0 - thanks everyone.

@albertolina
Copy link

Getting the following error:

flutter: Null check operator used on a null value
flutter: #0      convertPlatformException (package:firebase_remote_config_platform_interface/src/method_channel/utils/exception.dart:9:5)
#1      MethodChannelFirebaseRemoteConfig.fetchAndActivate (package:firebase_remote_config_platform_interface/src/method_channel/method_channel_firebase_remote_config.dart:155:13)
<asynchronous suspension>
#2      RemoteConfig.fetchAndActivate (package:firebase_remote_config/src/remote_config.dart:86:26)
<asynchronous suspension>

Edit: Same reason for the build failing: https://github.com/FirebaseExtended/flutterfire/pull/5686/checks?check_run_id=2288832143#step:6:265

Hello, I am getting the same error when I try to initialise remote config. Any solutions?

The error appears when I run:
final RemoteConfig remoteConfig = await RemoteConfig.instance; final defaults = <String, dynamic>{'welcome': 'default welcome'}; await remoteConfig.setDefaults(defaults);

Thank you!

@Salakar
Copy link
Member

Salakar commented Apr 21, 2021

@albertolina would you mind creating a new GitHub issue for your problem and add some more detail to it there and tag myself (@Salakar) and @rrousselGit in it - thanks.

@firebase firebase locked and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants