-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(firebase_remote_config)!: migrate to nullsafety #5686
Conversation
Looking forward to it :) |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
Getting the following error:
Edit: Same reason for the build failing: https://github.com/FirebaseExtended/flutterfire/pull/5686/checks?check_run_id=2288832143#step:6:265 |
Hello, is it ready? Can you merge it? |
We have some failing tests that needs to be fixed |
@rrousselGit How much time do you need? Can I help? |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
@rrousselGit waiting for your review! Everyone nice work with the update, thank you so much for your contributions! |
Are you going to make the release today? Or are you waiting on other fixes? |
You can always use something like this in the meantime:
Edit: I do get an exception on macOS. iOS seems to work fine |
This has now been published to pub.dev as |
Hello, I am getting the same error when I try to initialise remote config. Any solutions? The error appears when I run: Thank you! |
@albertolina would you mind creating a new GitHub issue for your problem and add some more detail to it there and tag myself (@Salakar) and @rrousselGit in it - thanks. |
Replacement for #5397