Test Upgrade to Serialport 4x #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be used in testing. By the 4.0.0 release I hope to have browser serialport in parity. SerialPort 4.0.0-rc1 is out and brings performance improvements, bug fixes and a few changes to the api. It's now out of sync with `browser-serialport` but not in a major way. garrows/browser-serialport#40 I suspect this upgrade won't have any far reaching effects as firmata uses only a fraction of the functions of SerialPort by default. The coms changes will be cleaner when browser serial port catches up.
reconbot
force-pushed
the
serialport-4.0.0-rc1
branch
from
9aa1813
to
61f9064
Compare
|
Tests are still not in great shape, they're written to the previous API |
|
I resolved this and landed a variant of the upgrade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be used in testing. By the 4.0.0 release I hope to have browser serialport in parity.
SerialPort
4.0.0-rc1is out and brings performance improvements, bug fixes and a few changes to the api. It's now out of sync withbrowser-serialportbut not in a major way. garrows/browser-serialport#40I suspect this upgrade won't have any far reaching unattended effects as firmata uses only a fraction of the functions of SerialPort by default. The coms changes will be cleaner when browser serial port catches up.