validations #32
validations #32
Conversation
There was a problem hiding this comment.
@fivetran-jamie this looks good to me! Thanks for your quick work with addressing this update. Just a few documentation comments to address before moving to release review.
CHANGELOG.md
Outdated
| @@ -1,3 +1,13 @@ | |||
| # dbt_microsoft_ads v0.8.0 | |||
|
|
|||
| *See parallel upstream [release](https://github.com/fivetran/dbt_microsoft_ads_source/releases) of source package.* | |||
There was a problem hiding this comment.
Can you include the specific release of the source package here.
There was a problem hiding this comment.
Actually, I know it is duplicative but can we include the relevant release notes from the source package here. Just to make it easier for folks to follow along as to why this is being marked as a breaking change.
packages.yml
Outdated
| - package: fivetran/microsoft_ads_source | ||
| version: [">=0.8.0", "<0.9.0"] | ||
| # - package: fivetran/microsoft_ads_source | ||
| # version: [">=0.9.0", "<0.10.0"] | ||
| - git: https://github.com/fivetran/dbt_microsoft_ads_source.git | ||
| revision: bugfix/campaign-report-add-budget |
There was a problem hiding this comment.
Reminder to swap before release.
There was a problem hiding this comment.
@fivetran-jamie Also a small question here but otherwise looks good!
CHANGELOG.md
Outdated
| ### Under the Hood | ||
| - Included auto-releaser GitHub Actions workflow to automate future releases. | ||
| - Updated the PR Templates for package maintainers to our most up-to-date standards. | ||
| - Upgraded integration test dbt-adapter versions. |
There was a problem hiding this comment.
Just a suggestion--maybe we can remove this under the hood section? Just to avoid confusion with the first one, and this doesn't really affect this package?
There was a problem hiding this comment.
ah yeah that's a good call!
PR Overview
This PR will address the following Issue/Feature:
fivetran/dbt_microsoft_ads_source#30 by way of including fivetran/dbt_microsoft_ads_source#31
This PR will result in the following new package version:
v0.8.0 -- breaking change upstream
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
See parallel upstream release of source package.
PR #32 includes the following updates:
Under the Hood
microsoft_ads__campaign_reporttable (to be used only by maintainers).PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
see consistency test added
If you had to summarize this PR in an emoji, which would it be?
🧪