-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new budget fields to campaign_daily_report + adjust uniqueness test #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie thanks for the quick work on this PR! This looks good to me with one small request to reword the CHANGELOG.
Co-authored-by: Joe Markiewicz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie Just a doc suggestion here but otherwise lgtm!
Co-authored-by: fivetran-catfritz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
PR Overview
This PR will address the following Issue/Feature:
#30
This PR will result in the following new package version:
v0.9.0 -- new fields and new grain of PK testing
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Bug Fixes
budget_name
andbudget_status
fields to theCAMPAIGN_PERFORMANCE_DAILY_REPORT
source table. These fields are now:stg_microsoft_ads__campaign_daily_report
model.stg_microsoft_ads__campaign_daily_report
, as they affect the grain of the report and may have therefore induced uniqueness test failures.budget_association_status
field (also fromCAMPAIGN_PERFORMANCE_DAILY_REPORT
).Under the Hood
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
See consistency validations in fivetran/dbt_microsoft_ads#32
Moreover, can confirm that the new fields show up in the staging model
If you had to summarize this PR in an emoji, which would it be?
💸