Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Passthrough Variable #12

Merged
merged 7 commits into from
Jun 9, 2021
Merged

Conversation

DylanBaker
Copy link
Contributor

Are you a current Fivetran customer?

Dylan, Fivetran

What change(s) does this PR introduce?

Allows additional metrics to be defined and added as pass-through metrics.

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide explanation how the change is non breaking below.)

Is this PR in response to a previously created Issue

How did you test the PR changes?

  • CircleCi
  • Other (please provide additional testing details below)

@fivetran-joemarkiewicz fivetran-joemarkiewicz self-assigned this Jun 4, 2021
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I made an update to the variable that I would like to get your eyes on. See my approval comment within the source PR

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 357088b into master Jun 9, 2021
@fivetran-joemarkiewicz fivetran-joemarkiewicz deleted the passthrough_variable branch June 9, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants