[do-not-merge] backend/vxlan: Remove local broadcast route for network #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc also @bison |
|
Posted to netdev asking about why the Kernel does this: http://marc.info/?l=linux-netdev&m=148132848222491&w=2 |
tomdee
approved these changes
Dec 12, 2016
steveej
reviewed
Dec 12, 2016
| @@ -28,6 +28,8 @@ import ( | |||
| "github.com/coreos/flannel/pkg/ip" | |||
| ) | |||
|
|
|||
| const RTN_BROADCAST = 3 | |||
There was a problem hiding this comment.
the syscall package defines this constant
aaronlevy
changed the title
|
Issue this PR was trying to address was resolved by: #576 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #533
Fixes #535
This change will remove the broadcast route added to the local route table when the vxlan interface is setup. By removing the route entry, the node will be able to properly route traffic meant for the host assigned the network address within the in flannel network (see issue/533 for more info).
While this may seem a bit heavy-handed - if flannel is restarted, the broadcast routes will not be re-created anyway.
/cc @tomdee @philips