backend/vxlan: Set the netmask of the IP used for the vxlan device #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a /32 netmask for the vxlan device. This avoids the kernel programming broadcast routes (which won't work). Unicast routes are already explicitly programmed so there's no need to use a broader netmask.
aaronlevy
reviewed
Dec 14, 2016
| // Ensure that the device has a /32 address so that no broadcast routes are created. | ||
| // This IP is just used as a source address for host to workload traffic (so | ||
| // the return path for the traffic has a decent address to use as the destination) | ||
| ipn.Mask = net.CIDRMask(32, 32) |
There was a problem hiding this comment.
really minor nit: may want this in the caller if want to keep setAddr4 generic. Or if this is the only use case (which I believe it is), may as well only require caller to provide anIP rather than IPNet.
|
Cool! Merging. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a /32 netmask for the vxlan device. This avoids the kernel programming
broadcast routes (which won't work).
Unicast routes are already explicitly programmed so there's no need to
use a broader netmask.