This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
Fixed coloring values when filter is -1 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diafour
suggested changes
Mar 4, 2020
swap condition in filter: first checking if null and then if it's equal to "-1" Co-Authored-By: Ivan Mikheykin <[email protected]>
|
Totally agree with the swap :) |
|
Hello! There is a small suggestion in the review. I still don't get the idea behind the P.S. I've moved the discussion about pagination in the relevant issue #83. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @diafour !
Thank you very much for merged the previous PR! I just fixed the problem you mentined before that occurs when you filter by "-1" (about not coloring right the cards values).
Also I finished the other functionality I told you in #86 about pagination. I attach some pics of how it is, so you can check it before opening a new PR.
Thank you very much in advance!