This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
ref: one codebase for the hover tooltip and the frozen tooltip #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename variables for URL template, use templateSrv to render URL links - fix visibility of tooltip items and url template help popup whe the light theme is used - rework Tooltip settings pane, organize tooltip editor fields - rename properties in panel config, implement migration logic for legacy configuration - close button for the frozen tooltip - use relative positioning for proper page scrolling
This was referenced Jul 9, 2020
That is a simple converter for initial |
|
@kevinbin does `${__graph_range} works earlier? It looks that "system" variables are missing, I check this. |
|
Oops, I got it. The popup for URL template is not updated. The variable for time range is I'll fix the help message. |
|
Does the variable for time range support in grafana 6.x ? |
|
Yes. The plugin sets this variable, so it works in 5.4.x as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #86. It addresses suggestions in this comment: #86 (comment).
Hover tooltip and frozen tooltip display similar content now. What you see on mouseover, is what you get on click. No ambiguity for mobile users.
Filtering by index is fixed earlier, in Fixed coloring values when filter is -1 #91.
'Tooltip' settings pane is reworked, fields are reorganized. It is compatible with the new layout of 'Edit mode' in Grafana 7.
Variable names are renamed.
$timebecome${__url_time_range}without leading&— Grafana 7 has this variable.$series_labelbecome${__y_label}$series_extrabecome${__value}and${__value_N}similar to 'table' plugin.${__value_date}and${__value_N_date}variables and 'Date format' field.Url section in the tooltip and Help popup is now visible when the light theme is used.
Known issues:
leftposition. It doesn't follow a bucket on time range refresh and on panel resize.