Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

Feature/pagination #93

Conversation

JoaquinJimenezGarcia
Copy link
Contributor

Added the posibility to paginate elements.

Also, it includes a new ID per each panel which allows the user to request the page size and the current page by the URL.

It has been fixed error mentioned #92

…l links. Which links can be created with values from the series.
@JoaquinJimenezGarcia
Copy link
Contributor Author

Hi @diafour !

Is everything ok? Did you have time to check the new changes? I could help you if you need something.

Thank you very much in advance!

@diafour
Copy link
Collaborator

diafour commented Mar 25, 2020

@JoaquinJimenezGarcia hello! I am stuck with tooltips combining right now. I will test this PR this week.

There is one thing.. I've renamed some panel settings, e.g. url is moved to tooltip.urls and usingUrl is now tooltip.freezeOnClick — is it a problem for your setup? Should I make a simple converter in a StatusHeatmapCtrl constructor to support original settings?

@JoaquinJimenezGarcia
Copy link
Contributor Author

Hello @diafour ! Thank you for your comment. It will be awesome if your could make that simple converter.

Thank you very much!

@JoaquinJimenezGarcia
Copy link
Contributor Author

Hi @diafour ! How is it going?

@Matkill
Copy link

Matkill commented May 29, 2020

Hello, i have the same issue when i add an url on the status map
image

the extratooltip does not show the link
image

and i have this error in the console when i click on the green status

image

How can i solve this ?

Thanks for your work and your help on that !

…the dashboards because these variables are not in the panel settings anymore
diafour pushed a commit that referenced this pull request Jul 13, 2020
Continuation of PR #93.
diafour added a commit that referenced this pull request Jul 13, 2020
Continuation of PR #93.

- reworked layout for paginations controls on graph
- use BucketMatrixPager for pagination logic and state
@diafour diafour mentioned this pull request Jul 13, 2020
diafour added a commit that referenced this pull request Jul 13, 2020
Continuation of PR #93.

- reworked layout for pagination controls on graph
- use BucketMatrixPager for pagination logic and state
diafour added a commit that referenced this pull request Jul 13, 2020
Continuation of PR #93.

- reworked layout for pagination controls on graph
- use BucketMatrixPager for pagination logic and state
@diafour
Copy link
Collaborator

diafour commented Jul 13, 2020

@JoaquinJimenezGarcia sorry for the long delay reviewing this PR. I've rebased this PR onto master and create a new PR #112 with squashed commit authored by you and make some changes so pagination now works with bucketMatrix structure instead of cardsData. Thank you for your contribution and efforts!

@diafour diafour closed this Jul 13, 2020
diafour added a commit that referenced this pull request Jul 13, 2020
feat: pagination

See issue #83, pulls: #93 and #112.
@diafour diafour added this to the 0.3.0 milestone Jul 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants