Move Typescript configuration to webpack config from core #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
askvortsov1
approved these changes
May 12, 2021
| return entries; | ||
| })(), | ||
| resolve: { | ||
| extensions: ['.ts', '.tsx', '.js', '.jsx', '.json'], |
There was a problem hiding this comment.
Why json? Approved since this was in the other PR too, so I assume there's a good reason
There was a problem hiding this comment.
Webpack/Babel can cleanly handle the importing of JSON.
This could be useful for an extension that wanted to load a large dataset and modify the frontend using that data.
Maybe some data exported from another system which is then used to add a page to the forum, like a leaderboard for a game server?
askvortsov1
approved these changes
May 12, 2021
| return entries; | ||
| })(), | ||
| resolve: { | ||
| extensions: ['.ts', '.tsx', '.js', '.jsx', '.json'], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables Typescript support on extensions by shifting the temporary setup from flarum/core to this repo.
tsconfig.jsonis provided using the new flarum/flarum-tsconfig repo.This is largely based on @datitisev's draft PR (#3).
Fixes flarum/framework#2343