-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeScript support #3
Conversation
Especially since it only adds typescript support and doesn't change anything else I'd say go for it. |
We'd probably publish this as beta 11 after merging to be able to easily use in flarum/core to start converting to TS. |
@datitisev would you be comfortable merging this now and publishing so we can use it in core, and putting the core extension stuff in a second (soon to follow) release? Or do you prefer that we release both at the same time? I just feel like we need some more discussion on the other one, but this one seems good to go |
@askvortsov1 We don't need to publish this yet. My PR has a temporary TS configuration (suggested by Franz) so that we don't have to publish this yet, specially if problems arise. |
This allows us to get started with converting all Flarum JavaScript code to TypeScript. In addition, we will have time to experiment to find the best Webpack configuration before integrating into flarum-webpack-config. See flarum/flarum-webpack-config#3.
Switched to draft so that we remember to revisit this and make the proper changes. |
I'm just curious, but why do we need all the extra options compared to our existing TS shim used in core? |
Superseded by #11. |
Support TypeScript
forum.ts
&admin.ts
tsconfig.json
Don't think all those config keys are needed, but to make code editors a bit happier when linting
tsconfig.json
is not required in projects, but code editors will want it - its contents can just beHow do we want to add this to core?
Perhaps publish a beta 11 (I changed the version here to beta.11-dev)? That might be the easiest way.