Permissions Cleanup: Core

[askvortsov1]

Fixes #1680

Changes proposed in this pull request:

• Rename viewDiscussions to viewForum
• Rename viewUserList to searchUsers
• Revert 40e4c0a
• Add migrations to update permission keys
• Fix an improperly configured test

Reviewers should focus on:
This is marked as draft until we agree upon #2202

Confirmed

• Frontend changes: tested on a local Flarum installation.
• Backend changes: tests are green (run composer test).

[dsevillamartin]

I do not think we should change the viewUserList permission to searchUsers as that is still misleading with its current behavior. It doesn't only prevent searching users, but also from visiting user profiles directly.

[askvortsov1]

That's also changed though, see the modifications to User Policy

[dsevillamartin]

Ah I see. That wasn't clear from the PR description so I got confused. 👍

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum.
In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

[askvortsov1]

If this happens, it will happen in a separate PR.