Revert https://github.com/flarum/core/pull/1536 #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
requested review from
dsevillamartin,
clarkwinkelmann,
luceos and
tankerkiller125
tankerkiller125
approved these changes
Sep 24, 2020
|
Context? All the linked stuff seems to be from 2018? |
|
Sorry about that, I've updated the PR description. |
clarkwinkelmann
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1680. The rest will be fixed in #2212, but we can get this particular bug fixed in time for the next release.
Essentially, among our permission scheme, we have the
viewDiscussionsandviewUserListpermissions. The first actually serves as a generic access permission for the entire forum, while the second is intended for the LIST users API. IE,viewUserListcontrols whether the list of users can be searched. This is further explained in #1680 (comment).This PR fixes the second part of that comment, so that people stop seeing errors when refreshing the page after going to a user profile. This means that the
viewUserListpermission can now be used as intended, and unnecessary user searching can be restricted.The rest (renaming permissions) will be done in #2212, but we need to discuss (and agree upon) a permission naming convention first.