[feat][DVO-212] Make memcached client timeout configurable #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #337 +/- ##
==========================================
- Coverage 17.90% 17.89% -0.01%
==========================================
Files 20 20
Lines 3743 3745 +2
==========================================
Hits 670 670
- Misses 2990 2992 +2
Partials 83 83
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The default value of `100ms` for `memcached` client timeout might not always be sufficient. Therefore, we would like to be able to fine-tune this parameter via environment var.
0x416e746f6e
force-pushed
the
feature/dvo-212-investigate-memcached-connection-issues
branch
from
2752a68
to
650be2e
Compare
|
That's great, thanks! Could you please rebase on latest main? |
|
btw, i think this is missing the |
4 tasks
|
replaced by #341 because if urgency |
metachris
deleted the
feature/dvo-212-investigate-memcached-connection-issues
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Use
MEMCACHED_CLIENT_TIMEOUT_MSenv var to configure the timeout formemcachedclient.⛱ Motivation and Context
The default value of
100msformemcachedclient timeout might not always be sufficient.Therefore, we would like to be able to fine-tune this parameter via environment var.
✅ I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md