Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memcached timeout + max-idle-conns #341

Merged
merged 1 commit into from
Apr 9, 2023
Merged

memcached timeout + max-idle-conns #341

merged 1 commit into from
Apr 9, 2023

Conversation

metachris
Copy link
Collaborator

📝 Summary

Memcached config options: MEMCACHED_CLIENT_TIMEOUT_MS and MEMCACHED_MAX_IDLE_CONNS

Replaces #337


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2023

Codecov Report

Merging #341 (a4ddeaa) into main (92648da) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   17.93%   17.91%   -0.02%     
==========================================
  Files          20       20              
  Lines        3658     3661       +3     
==========================================
  Hits          656      656              
- Misses       2920     2923       +3     
  Partials       82       82              
Flag Coverage Δ
unittests 17.91% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datastore/memcached.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Base automatically changed from multi-payload-attributes to main April 9, 2023 14:43
@metachris metachris merged commit ad167db into main Apr 9, 2023
@metachris metachris deleted the memcached-timeout branch April 9, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants