Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getPayload only to origin relays #342

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Conversation

metachris
Copy link
Collaborator

📝 Summary

Send getPayload requests only to the relays that sent the bid

⛱ Motivation and Context

Currently getPayload is sent to all relays, which will result in a bunch of errors in the logs because most relays won't know about the requested payload.


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy

@metachris metachris force-pushed the getpayload-only-to-origin-relay branch from 911db00 to d2fd6b5 Compare September 22, 2022 07:53
@codecov-commenter
Copy link

Codecov Report

Merging #342 (d2fd6b5) into main (e1bce51) will increase coverage by 0.74%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
+ Coverage   81.22%   81.96%   +0.74%     
==========================================
  Files           5        5              
  Lines         671      682      +11     
==========================================
+ Hits          545      559      +14     
+ Misses         95       94       -1     
+ Partials       31       29       -2     
Flag Coverage Δ
unittests 81.96% <100.00%> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/utils.go 72.46% <ø> (ø)
server/mock_relay.go 86.84% <100.00%> (+0.08%) ⬆️
server/relay_entry.go 87.50% <100.00%> (+4.16%) ⬆️
server/service.go 80.14% <100.00%> (+0.93%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Ruteri
Ruteri previously approved these changes Sep 22, 2022
server/service.go Outdated Show resolved Hide resolved
@metachris
Copy link
Collaborator Author

fwiw, confirmed working on sepolia, thanks Kiln 🙏

@metachris metachris merged commit bccaf78 into main Sep 22, 2022
@metachris metachris deleted the getpayload-only-to-origin-relay branch September 22, 2022 09:58
kailinr pushed a commit that referenced this pull request Sep 25, 2022
metachris added a commit that referenced this pull request Sep 25, 2022
* Update README.md (#334)

* Readme Usage updat

* Add security audit, make clone section more explicit

* update MEV vs mev, adjust language, typos

* remove The Plan

* correct line 17 capitalization

* Add space to line 182

Co-authored-by: shana <[email protected]>

* add security link to line 20

* Rmve TOC header from line 40

* Remve checkout release instructions from line 111

* add beacon node to distinction to ln 16

* update line 17, change markdown of line 47-49 titles

* remove mrkdown line 205 by chris

Co-authored-by: Chris Hager <[email protected]>

* getPayload only to origin relays (#342)

* v1.3.2

* v1.3.3-dev

* Improved documentation and checklist for releasing a new version (#343)

* improved documentation around release process

* RELEASE.md

* readme: link to remroy's guide (#344)

* Print relays/monitors on individual lines (#349)

* release checklist: create a signed tag (#346)

* Add gofumpt to lint checks (#347)

* Remove unnecessary log.withField calls (#350)

Co-authored-by: Chris Hager <[email protected]>

* fix the spelling of 'Rémy Roy'

* line 81 header

* address Chris's comments

Co-authored-by: Nicolas Moreau <[email protected]>
Co-authored-by: shana <[email protected]>
Co-authored-by: Chris Hager <[email protected]>
Co-authored-by: Justin Traglia <[email protected]>
screwyprof pushed a commit to screwyprof/mev-boost that referenced this pull request Feb 3, 2023
screwyprof pushed a commit to screwyprof/mev-boost that referenced this pull request Feb 3, 2023
…#339)

* Update README.md (flashbots#334)

* Readme Usage updat

* Add security audit, make clone section more explicit

* update MEV vs mev, adjust language, typos

* remove The Plan

* correct line 17 capitalization

* Add space to line 182

Co-authored-by: shana <[email protected]>

* add security link to line 20

* Rmve TOC header from line 40

* Remve checkout release instructions from line 111

* add beacon node to distinction to ln 16

* update line 17, change markdown of line 47-49 titles

* remove mrkdown line 205 by chris

Co-authored-by: Chris Hager <[email protected]>

* getPayload only to origin relays (flashbots#342)

* v1.3.2

* v1.3.3-dev

* Improved documentation and checklist for releasing a new version (flashbots#343)

* improved documentation around release process

* RELEASE.md

* readme: link to remroy's guide (flashbots#344)

* Print relays/monitors on individual lines (flashbots#349)

* release checklist: create a signed tag (flashbots#346)

* Add gofumpt to lint checks (flashbots#347)

* Remove unnecessary log.withField calls (flashbots#350)

Co-authored-by: Chris Hager <[email protected]>

* fix the spelling of 'Rémy Roy'

* line 81 header

* address Chris's comments

Co-authored-by: Nicolas Moreau <[email protected]>
Co-authored-by: shana <[email protected]>
Co-authored-by: Chris Hager <[email protected]>
Co-authored-by: Justin Traglia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants