Remove unnecessary log.WithField calls #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #350 +/- ##
==========================================
+ Coverage 81.02% 81.47% +0.44%
==========================================
Files 5 5
Lines 680 680
==========================================
+ Hits 551 554 +3
+ Misses 97 95 -2
+ Partials 32 31 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
metachris
approved these changes
Sep 24, 2022
kailinr
pushed a commit
that referenced
this pull request
Sep 25, 2022
Co-authored-by: Chris Hager <[email protected]>
metachris
added a commit
that referenced
this pull request
Sep 25, 2022
* Update README.md (#334) * Readme Usage updat * Add security audit, make clone section more explicit * update MEV vs mev, adjust language, typos * remove The Plan * correct line 17 capitalization * Add space to line 182 Co-authored-by: shana <[email protected]> * add security link to line 20 * Rmve TOC header from line 40 * Remve checkout release instructions from line 111 * add beacon node to distinction to ln 16 * update line 17, change markdown of line 47-49 titles * remove mrkdown line 205 by chris Co-authored-by: Chris Hager <[email protected]> * getPayload only to origin relays (#342) * v1.3.2 * v1.3.3-dev * Improved documentation and checklist for releasing a new version (#343) * improved documentation around release process * RELEASE.md * readme: link to remroy's guide (#344) * Print relays/monitors on individual lines (#349) * release checklist: create a signed tag (#346) * Add gofumpt to lint checks (#347) * Remove unnecessary log.withField calls (#350) Co-authored-by: Chris Hager <[email protected]> * fix the spelling of 'Rémy Roy' * line 81 header * address Chris's comments Co-authored-by: Nicolas Moreau <[email protected]> Co-authored-by: shana <[email protected]> Co-authored-by: Chris Hager <[email protected]> Co-authored-by: Justin Traglia <[email protected]>
screwyprof
pushed a commit
to screwyprof/mev-boost
that referenced
this pull request
Feb 3, 2023
Co-authored-by: Chris Hager <[email protected]>
screwyprof
pushed a commit
to screwyprof/mev-boost
that referenced
this pull request
Feb 3, 2023
…#339) * Update README.md (flashbots#334) * Readme Usage updat * Add security audit, make clone section more explicit * update MEV vs mev, adjust language, typos * remove The Plan * correct line 17 capitalization * Add space to line 182 Co-authored-by: shana <[email protected]> * add security link to line 20 * Rmve TOC header from line 40 * Remve checkout release instructions from line 111 * add beacon node to distinction to ln 16 * update line 17, change markdown of line 47-49 titles * remove mrkdown line 205 by chris Co-authored-by: Chris Hager <[email protected]> * getPayload only to origin relays (flashbots#342) * v1.3.2 * v1.3.3-dev * Improved documentation and checklist for releasing a new version (flashbots#343) * improved documentation around release process * RELEASE.md * readme: link to remroy's guide (flashbots#344) * Print relays/monitors on individual lines (flashbots#349) * release checklist: create a signed tag (flashbots#346) * Add gofumpt to lint checks (flashbots#347) * Remove unnecessary log.withField calls (flashbots#350) Co-authored-by: Chris Hager <[email protected]> * fix the spelling of 'Rémy Roy' * line 81 header * address Chris's comments Co-authored-by: Nicolas Moreau <[email protected]> Co-authored-by: shana <[email protected]> Co-authored-by: Chris Hager <[email protected]> Co-authored-by: Justin Traglia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
WithFieldcalls with hardcoded values that aren't really that useful.⛱ Motivation and Context
✅ I have run these commands
make lintmake test-racego mod tidy