Skip to content

Commit

Permalink
Remove unused code from licenses script (#6910)
Browse files Browse the repository at this point in the history
Code became obsolete with #3627.

Also fixes mix-in syntax and marks class as private. With the latter the anaylser tells us in the future if there are unused classes in the file.
  • Loading branch information
goderbauer authored Nov 20, 2018
1 parent 3822765 commit dda9f69
Show file tree
Hide file tree
Showing 3 changed files with 298 additions and 573 deletions.
2 changes: 0 additions & 2 deletions tools/licenses/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# Specify analysis options.

analyzer:
language:
enableSuperMixins: true
strong-mode:
implicit-dynamic: false
errors:
Expand Down
18 changes: 6 additions & 12 deletions tools/licenses/lib/filesystem.dart
Original file line number Diff line number Diff line change
Expand Up @@ -308,8 +308,7 @@ abstract class TextFile extends File {
String readString();
}

// mixin
abstract class UTF8TextFile extends TextFile {
mixin UTF8TextFile implements TextFile {
@override
String readString() {
try {
Expand All @@ -321,8 +320,7 @@ abstract class UTF8TextFile extends TextFile {
}
}

// mixin
abstract class Latin1TextFile extends TextFile {
mixin Latin1TextFile implements TextFile {
@override
String readString() {
return cache(new Latin1Of(this), () {
Expand Down Expand Up @@ -350,8 +348,7 @@ abstract class Directory extends IoNode {
// interface
abstract class Link extends IoNode { }

// mixin
abstract class ZipFile extends File implements Directory {
mixin ZipFile on File implements Directory {
ArchiveDirectory _root;

@override
Expand All @@ -366,8 +363,7 @@ abstract class ZipFile extends File implements Directory {
}
}

// mixin
abstract class TarFile extends File implements Directory {
mixin TarFile on File implements Directory {
ArchiveDirectory _root;

@override
Expand All @@ -382,8 +378,7 @@ abstract class TarFile extends File implements Directory {
}
}

// mixin
abstract class GZipFile extends File implements Directory {
mixin GZipFile on File implements Directory {
InMemoryFile _data;

@override
Expand All @@ -400,8 +395,7 @@ abstract class GZipFile extends File implements Directory {
}
}

// mixin
abstract class BZip2File extends File implements Directory {
mixin BZip2File on File implements Directory {
InMemoryFile _data;

@override
Expand Down
Loading

0 comments on commit dda9f69

Please sign in to comment.