Remove unused code from licenses script #6910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code became obsolete with flutter#3627. Also fixes mix-in syntax and marks class as private. With the latter the anaylser tells us in the future if there are unused classes in the file.
|
The yellow check actually passed, but didn't update on github. |
|
This broke linux buildbot (and dart flutter head-head-head as well). |
|
Can you please link to the failure? |
|
There's a version missmatch between the Dart SDK used on the Chromebots and the one that shipps with Flutter. Fix is flutter/buildroot#192 and #6916. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 21, 2018
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Nov 21, 2018
flutter/engine@1baf081...8d38417 git log 1baf081..8d38417 --no-merges --oneline 8d38417 Roll buildroot to 7e555aec776cfda9ab2e898f83dccef3005795c2 (flutter/engine#6916) dda9f69 Remove unused code from licenses script (flutter/engine#6910) 3822765 Roll src/third_party/skia 6bdfb6fba352..eb35650f9177 (15 commits) (flutter/engine#6914) 983d70e Revert "Compile libcxx and libcxxabi for Android (#6886)" (flutter/engine#6912) 9ccd1e8 Compile libcxx and libcxxabi for Android (flutter/engine#6886) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
ele828
added a commit
to ele828/engine
that referenced
this pull request
Dec 9, 2018
Code became obsolete with flutter#3627. Also fixes mix-in syntax and marks class as private. With the latter the anaylser tells us in the future if there are unused classes in the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code became obsolete with #3627.
Also fixes mix-in syntax and marks class as private. With the latter the anaylser tells us in the future if there are unused classes in the file.