Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to demo game #1506

Merged
merged 2 commits into from
Oct 6, 2015
Merged

Fixes to demo game #1506

merged 2 commits into from
Oct 6, 2015

Conversation

vlidholt
Copy link
Contributor

@vlidholt vlidholt commented Oct 6, 2015

  • Fixes drawing issue on main screen
  • Improvements to physics


if (_body == null)
return;
for(box2d.Fixture f = _body.getFixtureList(); f != null; f = f.getNext()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually put a space after for

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, will add

@abarth
Copy link
Contributor

abarth commented Oct 6, 2015

LGTM

vlidholt added a commit that referenced this pull request Oct 6, 2015
@vlidholt vlidholt merged commit eb2709e into flutter:master Oct 6, 2015
rhencke pushed a commit to rhencke/engine that referenced this pull request Dec 20, 2020
* Basic functionality for typed functions without typedefs

* Refactor and add more tests

* dartfmt

* Move constructor logic to a more logical place

* Make AppVeyor run pub get for the test package as well to regenerate .packages

* Doc update

* appveyor experiment

* appveyor experiment 2

* appveyor experiment flutter#3

* update pubspec.locks

* Fix private detection to include dart:_ prefix

* travis experiment

* travis experiment 2

* travis experiment 3

* Reset to 05ddca020be7badeff33bdbcecf1782da849f3a7

* Fix private detection to include dart:_ prefix

* Review comments

* typo
rhencke pushed a commit to rhencke/engine that referenced this pull request Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants