Merge pull request flutter#1506 from dart-lang/rename_spread_collections

Rename spread collections
rhencke · Apr 7, 2019 · 4f66a45 · 4f66a45
2 parents 0b67ec3 + 0af34d7
commit 4f66a45
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/example/all.yaml b/example/all.yaml
@@ -107,6 +107,7 @@ linter:
     - prefer_mixin
     - prefer_null_aware_operators
     - prefer_single_quotes
+    - prefer_spread_collections
     - prefer_typing_uninitialized_variables
     - prefer_void_to_null
     - provide_deprecation_message
@@ -116,7 +117,6 @@ linter:
     - sort_constructors_first
     - sort_pub_dependencies
     - sort_unnamed_constructors_first
-    - spread_collections
     - test_types_in_equals
     - throw_in_finally
     - type_annotate_public_apis

diff --git a/lib/src/rules.dart b/lib/src/rules.dart
@@ -108,6 +108,7 @@ import 'package:linter/src/rules/prefer_iterable_whereType.dart';
 import 'package:linter/src/rules/prefer_mixin.dart';
 import 'package:linter/src/rules/prefer_null_aware_operators.dart';
 import 'package:linter/src/rules/prefer_single_quotes.dart';
+import 'package:linter/src/rules/prefer_spread_collections.dart';
 import 'package:linter/src/rules/prefer_typing_uninitialized_variables.dart';
 import 'package:linter/src/rules/prefer_void_to_null.dart';
 import 'package:linter/src/rules/provide_deprecation_message.dart';
@@ -118,7 +119,6 @@ import 'package:linter/src/rules/recursive_getters.dart';
 import 'package:linter/src/rules/slash_for_doc_comments.dart';
 import 'package:linter/src/rules/sort_constructors_first.dart';
 import 'package:linter/src/rules/sort_unnamed_constructors_first.dart';
-import 'package:linter/src/rules/spread_collections.dart';
 import 'package:linter/src/rules/super_goes_last.dart';
 import 'package:linter/src/rules/test_types_in_equals.dart';
 import 'package:linter/src/rules/throw_in_finally.dart';
@@ -255,6 +255,7 @@ void registerLintRules() {
     ..register(new PreferMixin())
     ..register(new PreferNullAwareOperators())
     ..register(new PreferSingleQuotes())
+    ..register(new PreferSpreadCollections())
     ..register(new PreferTypingUninitializedVariables())
     ..register(new PreferVoidToNull())
     ..register(new ProvideDeprecationMessage())
@@ -265,7 +266,6 @@ void registerLintRules() {
     ..register(new SortConstructorsFirst())
     ..register(new SortPubDependencies())
     ..register(new SortUnnamedConstructorsFirst())
-    ..register(new SpreadCollections())
     ..register(new SuperGoesLast())
     ..register(new TestTypesInEquals())
     ..register(new ThrowInFinally())

diff --git a/lib/src/rules/spread_collections.dart → lib/src/rules/prefer_spread_collections.dart b/lib/src/rules/spread_collections.dart → lib/src/rules/prefer_spread_collections.dart
@@ -67,10 +67,10 @@ var l = ['a', ...?things];
 ```
 ''';
 
-class SpreadCollections extends LintRule implements NodeLintRule {
-  SpreadCollections()
+class PreferSpreadCollections extends LintRule implements NodeLintRule {
+  PreferSpreadCollections()
       : super(
-            name: 'spread_collections',
+            name: 'prefer_spread_collections',
             description: _desc,
             details: _details,
             group: Group.style);

diff --git a/test/rules/spread_collections.dart → test/rules/prefer_spread_collections.dart b/test/rules/spread_collections.dart → test/rules/prefer_spread_collections.dart