Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fuchsia] Update Fuchsia API level to 15 #48233

Merged
merged 3 commits into from
Nov 29, 2023
Merged

[fuchsia] Update Fuchsia API level to 15 #48233

merged 3 commits into from
Nov 29, 2023

Conversation

jrwang
Copy link
Contributor

@jrwang jrwang commented Nov 20, 2023

Updates Fuchsia's API level to 15 (from 12).

b/307954008

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jrwang jrwang assigned jrwang and unassigned jrwang Nov 28, 2023
Copy link
Contributor

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter-lgtm

@jrwang jrwang merged commit 3056cc5 into flutter:main Nov 29, 2023
25 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 29, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 29, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 29, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 29, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 29, 2023
…139259)

flutter/engine@9a7e49d...35939ca

2023-11-29 [email protected] Roll Skia from eb6fc55a3bc5 to 010883e6572c (1 revision) (flutter/engine#48506)
2023-11-29 [email protected] Roll Skia from 830111a2c7d6 to eb6fc55a3bc5 (1 revision) (flutter/engine#48503)
2023-11-29 [email protected] [canvaskit] Disable createImageBitmap support on Chrome 110 or older on Windows. (flutter/engine#48475)
2023-11-29 [email protected] [fuchsia] Update Fuchsia API level to 15 (flutter/engine#48233)
2023-11-29 [email protected] Roll Skia from 8931060e9ab5 to 830111a2c7d6 (1 revision) (flutter/engine#48501)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@jrwang jrwang mentioned this pull request Dec 5, 2023
8 tasks
jrwang added a commit that referenced this pull request Dec 5, 2023
Sets enabled state in Fuchsia a11y via the accessibility bridge.

This was added in Fuchsia API v15, which Flutter is updated to use after
#48233.

b/261482081

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
caseycrogers pushed a commit to caseycrogers/flutter that referenced this pull request Dec 29, 2023
…lutter#139259)

flutter/engine@9a7e49d...35939ca

2023-11-29 [email protected] Roll Skia from eb6fc55a3bc5 to 010883e6572c (1 revision) (flutter/engine#48506)
2023-11-29 [email protected] Roll Skia from 830111a2c7d6 to eb6fc55a3bc5 (1 revision) (flutter/engine#48503)
2023-11-29 [email protected] [canvaskit] Disable createImageBitmap support on Chrome 110 or older on Windows. (flutter/engine#48475)
2023-11-29 [email protected] [fuchsia] Update Fuchsia API level to 15 (flutter/engine#48233)
2023-11-29 [email protected] Roll Skia from 8931060e9ab5 to 830111a2c7d6 (1 revision) (flutter/engine#48501)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@jrwang jrwang deleted the fuchsia-api branch February 6, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants