[canvaskit] Disable createImageBitmap support on Chrome 110 or older on Windows. #48475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Nov 29, 2023
| /// Detect if running on Chrome version 110 or older on Windows. | ||
| /// | ||
| /// These versions of Chrome have a bug on Windows which causes | ||
| /// rendering to be flipped upside down. |
There was a problem hiding this comment.
Maybe leave a TODO pointing to a Github issue to clean this up later?
harryterkelsen
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 29, 2023
… or older on Windows. (flutter/engine#48475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 29, 2023
… or older on Windows. (flutter/engine#48475)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 29, 2023
… or older on Windows. (flutter/engine#48475)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 29, 2023
…139259) flutter/engine@9a7e49d...35939ca 2023-11-29 [email protected] Roll Skia from eb6fc55a3bc5 to 010883e6572c (1 revision) (flutter/engine#48506) 2023-11-29 [email protected] Roll Skia from 830111a2c7d6 to eb6fc55a3bc5 (1 revision) (flutter/engine#48503) 2023-11-29 [email protected] [canvaskit] Disable createImageBitmap support on Chrome 110 or older on Windows. (flutter/engine#48475) 2023-11-29 [email protected] [fuchsia] Update Fuchsia API level to 15 (flutter/engine#48233) 2023-11-29 [email protected] Roll Skia from 8931060e9ab5 to 830111a2c7d6 (1 revision) (flutter/engine#48501) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
caseycrogers
pushed a commit
to caseycrogers/flutter
that referenced
this pull request
Dec 29, 2023
…lutter#139259) flutter/engine@9a7e49d...35939ca 2023-11-29 [email protected] Roll Skia from eb6fc55a3bc5 to 010883e6572c (1 revision) (flutter/engine#48506) 2023-11-29 [email protected] Roll Skia from 830111a2c7d6 to eb6fc55a3bc5 (1 revision) (flutter/engine#48503) 2023-11-29 [email protected] [canvaskit] Disable createImageBitmap support on Chrome 110 or older on Windows. (flutter/engine#48475) 2023-11-29 [email protected] [fuchsia] Update Fuchsia API level to 15 (flutter/engine#48233) 2023-11-29 [email protected] Roll Skia from 8931060e9ab5 to 830111a2c7d6 (1 revision) (flutter/engine#48501) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Chrome 110 or older, there is a bug where an ImageBitmap will be read back upside down if it is stored upside down on the GPU. This only happens on Windows. So if we are on Windows and running on Chrome 110 or older, then fall back to
drawImagebased rendering.Fixes flutter/flutter#138827
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.