Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web:tests] switch to new HTML DOM matcher #52354

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Apr 24, 2024

Remove the over-architected and under-utilized canonicalizeHtml and HtmlComparisonMode. Replace with a new hasHtml matcher.

The new matcher produces considerably better error messages when matching fails (see matchers_test.dart for multiple examples). It also allows focusing on particular parts of the DOM rather than looking for a full match. This way a test can test just the functionality it cares about, and it can skip specifying what unrelated parts should look like (i.e. it prevents over-testing). For example, let's say you want to test that an <flt-semantics> element has an aria-label attribute. You can use a DOM pattern that specified just that:

expect(
  element,
  hasHtml('<flt-semantics aria-label="hello"></flt-semantics>'),
)

This will check for the existence of <flt-semantics> and aria-label="hello". It will ignore everything else that's unrelated to ARIA labels. For example, the element may have its geometry specified in the style attribute, an id attribute, and many other things, but if the test doesn't care, it doesn't need to specify those things (it can, if needs to though). This also applies to style properties. See more examples in the matchers_test.dart file.

@yjbanov yjbanov requested a review from mdebbar April 24, 2024 03:23
@github-actions github-actions bot added the platform-web Code specifically for the web engine label Apr 24, 2024
@JS('innerHtml')
external set _innerHtml(JSString? html);
set innerHtml(String? html) => _innerHtml = html?.toJS;
@JS('innerHTML')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 24, 2024
@auto-submit auto-submit bot merged commit c469791 into flutter:main Apr 24, 2024
29 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 24, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 24, 2024
…147336)

flutter/engine@b5d5832...b30c0a7

2024-04-24 [email protected] Remove UIAccessibilityTraitKeyboardKey to fix touch typing (flutter/engine#52333)
2024-04-24 [email protected] [Impeller] Remove libtess2 from libflutter. (flutter/engine#52357)
2024-04-24 [email protected] Roll Skia from 510b6766d907 to afcc1db27593 (2 revisions) (flutter/engine#52367)
2024-04-24 [email protected] [web:tests] switch to new HTML DOM matcher (flutter/engine#52354)
2024-04-24 [email protected] [Impeller] use spec constant for gaussian shader, rename, and reuse vertex sources. (flutter/engine#52361)
2024-04-24 [email protected] [Impeller] delete points compute shader. (flutter/engine#52346)
2024-04-24 [email protected] [darwin] Update pixel format handling in FlutterTexture (flutter/engine#52326)
2024-04-24 [email protected] [Impeller] make drawAtlas always use porterduff or vertices_uber shader (flutter/engine#52348)
2024-04-24 [email protected] Migrate ios_surface files to ARC (flutter/engine#52139)
2024-04-24 [email protected] Roll Dart SDK from f470eaaf6e6d to 38c43a01a51e (1 revision) (flutter/engine#52365)
2024-04-24 [email protected] Roll Skia from b5dd23bd29df to 510b6766d907 (16 revisions) (flutter/engine#52364)
2024-04-24 [email protected] Fix some warnings reported by recent versions of clang-tidy (flutter/engine#52349)
2024-04-24 [email protected] Roll Skia from e15464e6e982 to b5dd23bd29df (1 revision) (flutter/engine#52353)
2024-04-24 [email protected] Roll Dart SDK from 5227dc5103f6 to f470eaaf6e6d (1 revision) (flutter/engine#52359)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants