Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Compile libcxx and libcxxabi for Android" #6912

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Revert "Compile libcxx and libcxxabi for Android" #6912

merged 1 commit into from
Nov 20, 2018

Conversation

goderbauer
Copy link
Member

Reverts #6886

Fails on bot for android_debug_arm64:

[3072/3085] SOLINK ./libflutter.so
FAILED: libflutter.so libflutter.so.TOC lib.stripped/libflutter.so 
/b/build/slave/goma_cache/client/gomacc ../../buildtools/linux-x64/clang/bin/clang++ -shared -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs --gcc-toolchain=../../third_party/android_tools/ndk/toolchains/aarch64-linux-android-4.9/prebuilt/linux-x86_64 -Wl,--no-undefined -Wl,--exclude-libs,ALL -fuse-ld=lld -Wl,--icf=all --target=aarch64-linux-android -Wl,--warn-shared-textrel -nostdlib --sysroot=/b/build/slave/Linux_Engine/build/src/third_party/android_tools/ndk/platforms/android-22/arch-arm64  -Wl,--warn-shared-textrel -Wl,-O2 -Wl,--gc-sections -Wl,--as-needed -flto -Wl,--version-script=../../build/android/android_only_explicit_jni_exports.lst -L../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libs/arm64-v8a -o ./libflutter.so -Wl,--build-id -Wl,-soname=libflutter.so @./libflutter.so.rsp && { /b/build/slave/goma_cache/client/gomacc ../../third_party/android_tools/ndk/toolchains/aarch64-linux-android-4.9/prebuilt/linux-x86_64/bin/aarch64-linux-android-readelf -d ./libflutter.so | grep SONAME ; /b/build/slave/goma_cache/client/gomacc ../../third_party/android_tools/ndk/toolchains/aarch64-linux-android-4.9/prebuilt/linux-x86_64/bin/aarch64-linux-android-nm -gD -f p ./libflutter.so | cut -f1-2 -d' '; } > ./libflutter.so.tmp && if ! cmp -s ./libflutter.so.tmp ./libflutter.so.TOC; then mv ./libflutter.so.tmp ./libflutter.so.TOC; fi && ../../third_party/android_tools/ndk/toolchains/aarch64-linux-android-4.9/prebuilt/linux-x86_64/bin/aarch64-linux-android-strip --strip-unneeded -o lib.stripped/libflutter.so.tmp libflutter.so && if ! cmp -s lib.stripped/libflutter.so.tmp lib.stripped/libflutter.so; then mv lib.stripped/libflutter.so.tmp lib.stripped/libflutter.so; fi
ld.lld: /b/s/w/ir/kitchen-workdir/llvm-project/llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:2401: llvm::Value *llvm::LibCallSimplifier::optimizeStringMemoryLibCall(llvm::CallInst *, IRBuilder<> &): Assertion `(ignoreCallingConv(Func) || isCallingConvCCompatible(CI)) && "Optimizing string/memory libcall would change the calling convention"' failed.
clang-8: error: unable to execute command: Aborted (core dumped)
clang-8: error: linker command failed due to signal (use -v to see invocation)

@goderbauer
Copy link
Member Author

/tbr @chinmaygarde

@goderbauer goderbauer merged commit 983d70e into master Nov 20, 2018
@goderbauer goderbauer deleted the revert-6886-compilelibcxx branch November 20, 2018 06:19
@chinmaygarde
Copy link
Member

lgtm

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 20, 2018
@engine-flutter-autoroll
983d70e Revert "Compile libcxx and libcxxabi for Android (flutter#6886)…
83df140 
…" (flutter/engine#6912)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 20, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 21, 2018
@engine-flutter-autoroll
983d70e Revert "Compile libcxx and libcxxabi for Android (flutter#6886)…
9bd9083 
…" (flutter/engine#6912)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 21, 2018
Merged
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Nov 21, 2018
@engine-flutter-autoroll
Roll engine 1baf081..8d38417 (5 commits) (#24593)
6bcad0f 
flutter/engine@1baf081...8d38417

git log 1baf081..8d38417 --no-merges --oneline
8d38417 Roll buildroot to 7e555aec776cfda9ab2e898f83dccef3005795c2 (flutter/engine#6916)
dda9f69 Remove unused code from licenses script (flutter/engine#6910)
3822765 Roll src/third_party/skia 6bdfb6fba352..eb35650f9177 (15 commits) (flutter/engine#6914)
983d70e Revert &#34;Compile libcxx and libcxxabi for Android (#6886)&#34; (flutter/engine#6912)
9ccd1e8 Compile libcxx and libcxxabi for Android (flutter/engine#6886)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/&#43;/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC&#39;d on the roll, and stop the roller if necessary.
ele828 added a commit to ele828/engine that referenced this pull request Dec 9, 2018
@ele828
Revert "Compile libcxx and libcxxabi for Android (flutter#6886)" (flu…
3f3fa86 
…tter#6912)

This reverts commit 9ccd1e8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes size
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goderbauer @chinmaygarde @googlebot