Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update templates to include google's maven repository #10842

Merged
merged 1 commit into from
Jun 20, 2017

Conversation

goderbauer
Copy link
Member

Going forward, Android support libraries are published on maven (instead of bundling them with the SDK). Many plugins depend on these. To avoid requiring plugin users to add the maven repository to their app this change adds the repository to the template for flutter create.

This also bumps the support-annotations dependency to 25.4.0 (which also requires the new maven repository).

Going forward, Android support libraries are published on maven (instead of bundling them with the SDK). Many plugins depend on these. To avoid requiring plugin users to add the maven repository to their app this change adds the repository to the template for `flutter create`.

This also bumps the support-annotations dependency to 25.4.0 (which also requires the new maven repository).
@goderbauer
Copy link
Member Author

See flutter/plugins#141.

Copy link
Contributor

@mravn-google mravn-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skybrian
Copy link
Contributor

Update the examples as well? (Could be a separate patch.)

@goderbauer
Copy link
Member Author

@skybrian will sent out a separate patch.

@goderbauer goderbauer merged commit 2f97991 into flutter:master Jun 20, 2017
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jul 1, 2017
Going forward, Android support libraries are published on maven (instead of bundling them with the SDK). Many plugins depend on these. To avoid requiring plugin users to add the maven repository to their app this change adds the repository to the template for `flutter create`.

This also bumps the support-annotations dependency to 25.4.0 (which also requires the new maven repository).
@goderbauer goderbauer deleted the updateTemplates branch September 25, 2017 22:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants