This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Update dependencies of plugins #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
force-pushed
the
bumpFirebaseVersion2
branch
2 times, most recently
from
8697740
to
4323622
Compare
|
I wonder if we should bump the version to 0.1.x for breaking changes so people on ^0.0.x won't get the upgrade by default. |
goderbauer
added a commit
to goderbauer/plugins
that referenced
this pull request
Jun 20, 2017
Travis uses the deprecated `android` CI to install the Android SDK. Unfortunatelly, at this point that outdated too is unable to install the latest version of the "Google Repository" Android SDK component. Switching to managing the Androd SDK by hand on Travis. That way, we can use `sdkmanager` (one of the replacements for `android`) and downlaod the latest versions of the Andorid SDK components. This change is required to update the plugin dependencies to the latest versions (flutter#141), which require the latest "Google Repository" version.
goderbauer
force-pushed
the
bumpFirebaseVersion2
branch
from
3bb4691
to
00a767c
Compare
goderbauer
commented
Jun 20, 2017
.travis.yml
Outdated
| @@ -70,15 +56,30 @@ matrix: | |||
| sources: | |||
| - ubuntu-toolchain-r-test # if we don't specify this, the libstdc++6 we get is the wrong version | |||
| packages: | |||
| - lib32stdc++6 # https://github.com/flutter/flutter/issues/6207 | |||
There was a problem hiding this comment.
Please ignore the changes in this file, I've send out these changes in a separate PR (#145) and will rebase this PR on top of the other.
|
Rebased & bumped versions. PTAL @collinjackson |
collinjackson
approved these changes
Jun 20, 2017
goderbauer
added a commit
that referenced
this pull request
Jun 20, 2017
Travis uses the deprecated `android` CI to install the Android SDK. Unfortunatelly, at this point that outdated too is unable to install the latest version of the "Google Repository" Android SDK component. Switching to managing the Androd SDK by hand on Travis. That way, we can use `sdkmanager` (one of the replacements for `android`) and downlaod the latest versions of the Andorid SDK components. This change is required to update the plugin dependencies to the latest versions (#141), which require the latest "Google Repository" version.
goderbauer
force-pushed
the
bumpFirebaseVersion2
branch
from
00a767c
to
f1583d8
Compare
HansMuller
pushed a commit
to HansMuller/plugins
that referenced
this pull request
Jun 30, 2017
Travis uses the deprecated `android` CI to install the Android SDK. Unfortunatelly, at this point that outdated too is unable to install the latest version of the "Google Repository" Android SDK component. Switching to managing the Androd SDK by hand on Travis. That way, we can use `sdkmanager` (one of the replacements for `android`) and downlaod the latest versions of the Andorid SDK components. This change is required to update the plugin dependencies to the latest versions (flutter#141), which require the latest "Google Repository" version.
HansMuller
pushed a commit
to HansMuller/plugins
that referenced
this pull request
Jun 30, 2017
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#10749.
Some of these changes are breaking changes as noted in the CHANGELOGs. I am preparing an email [1] that will be send out to flutter-users before publishing the updated plugins to pub. No action is required for new flutter apps (after flutter/flutter#10842 is merged). This is only a breaking change because of flutter/flutter#9881.
Plugin users will also have to make sure that they update their "Google Repository" version to 54 (or newer) in the Android SDK manager.
[1] https://docs.google.com/document/d/1B9RZ-PpdFKdgUvLxu1mvBxwG3ytDVJo0GFxCZVMyu0E/edit