Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Enable min SDK version checks #3095

Merged
merged 7 commits into from
Jan 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/scripts/prepare_tool.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ git fetch origin main

# Pinned version of the plugin tools, to avoid breakage in this repository
# when pushing updates from flutter/plugins.
dart pub global activate flutter_plugin_tools 0.13.2
dart pub global activate flutter_plugin_tools 0.13.4
5 changes: 4 additions & 1 deletion .cirrus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ task:
always:
format_script: ./script/tool_runner.sh format --fail-on-change
license_script: $PLUGIN_TOOL_COMMAND license-check
pubspec_script: ./script/tool_runner.sh pubspec-check
# The major and minor versions here should match the lowest version
# analyzed in legacy_version_analyze.
pubspec_script: ./script/tool_runner.sh pubspec-check --min-min-flutter-version=3.0.0 --min-min-dart-version=2.17.0
readme_script:
- ./script/tool_runner.sh readme-check
# Re-run with --require-excerpts, skipping packages that still need
Expand Down Expand Up @@ -157,6 +159,7 @@ task:
- name: legacy_version_analyze
depends_on: analyze
matrix:
# Change the arguments to pubspec-check when changing these values.
env:
CHANNEL: "3.0.5"
DART_VERSION: "2.17.6"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
with:
fetch-depth: 0 # Fetch all history so the tool can get all the tags to determine version.
- name: Set up tools
run: dart pub global activate flutter_plugin_tools 0.13.2
run: dart pub global activate flutter_plugin_tools 0.13.4

# # This workflow should be the last to run. So wait for all the other tests to succeed.
- name: Wait on all tests
Expand Down
1 change: 1 addition & 0 deletions packages/animations/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ version: 0.0.1

environment:
sdk: ">=2.12.0 <3.0.0"
flutter: ">=3.0.0"

dependencies:
animations:
Expand Down
4 changes: 4 additions & 0 deletions packages/cross_file/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## NEXT

* Updates minimum SDK version to Flutter 3.0.

## 0.3.3+2

* Fixes lint warnings in tests.
Expand Down
1 change: 1 addition & 0 deletions packages/cross_file/lib/src/types/html.dart
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ class XFile extends XFileBase {
///
/// `name` needs to be passed from the outside, since it's only available
/// while handling [html.File]s (when the ObjectUrl is created).
// ignore: use_super_parameters
XFile(
String path, {
String? mimeType,
Expand Down
4 changes: 2 additions & 2 deletions packages/cross_file/lib/src/types/interface.dart
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@ class XFile extends XFileBase {
/// `path` of the file doesn't match what the user sees when selecting it
/// (like in web)
XFile(
String path, {
super.path, {
String? mimeType,
String? name,
int? length,
Uint8List? bytes,
DateTime? lastModified,
@visibleForTesting CrossFileTestOverrides? overrides,
}) : super(path) {
}) {
throw UnimplementedError(
'CrossFile is not available in your current platform.');
}
Expand Down
1 change: 1 addition & 0 deletions packages/cross_file/lib/src/types/io.dart
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ class XFile extends XFileBase {
/// [bytes] is ignored; the parameter exists only to match the web version of
/// the constructor. To construct a dart:io XFile from bytes, use
/// [XFile.fromData].
// ignore: use_super_parameters
XFile(
String path, {
String? mimeType,
Expand Down
2 changes: 1 addition & 1 deletion packages/cross_file/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
version: 0.3.3+2

environment:
sdk: ">=2.12.0 <3.0.0"
sdk: ">=2.17.0 <3.0.0"

dependencies:
js: ^0.6.3
Expand Down
2 changes: 1 addition & 1 deletion packages/cross_file/test/x_file_io_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ void main() {

/// An XFile subclass that tracks reads, for testing purposes.
class TestXFile extends XFile {
TestXFile(String path) : super(path);
TestXFile(super.path);

bool hasBeenRead = false;

Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_lints/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A project that showcases how to enable the recommended lints for Fl
publish_to: none

environment:
sdk: '>=2.12.0 <3.0.0'
sdk: '>=2.17.0 <3.0.0'

# Add the latest version of `package:flutter_lints` as a dev_dependency. The
# lint set provided by this package is activated in the `analysis_options.yaml`
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_lints/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
version: 2.0.1

environment:
sdk: '>=2.17.0-0 <3.0.0'
sdk: '>=2.17.0 <3.0.0'

dependencies:
lints: ^2.0.0
Expand Down
4 changes: 4 additions & 0 deletions packages/flutter_template_images/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## NEXT

* Updates minimum SDK version to Flutter 3.0.

## 4.2.0

* Adds iOS template app icons, updated to square icons with no transparency.
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_template_images/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
version: 4.2.0

environment:
sdk: ">=2.12.0 <3.0.0"
sdk: ">=2.17.0 <3.0.0"
4 changes: 4 additions & 0 deletions packages/metrics_center/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## NEXT

* Updates minimum SDK version to Flutter 3.0.

## 1.0.6

- Fixes lint warnings.
Expand Down
2 changes: 1 addition & 1 deletion packages/metrics_center/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ repository: https://github.com/flutter/packages/tree/main/packages/metrics_cente
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+metrics_center%22

environment:
sdk: '>=2.12.0 <3.0.0'
sdk: '>=2.17.0 <3.0.0'

dependencies:
crypto: ^3.0.1
Expand Down
4 changes: 4 additions & 0 deletions packages/multicast_dns/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## NEXT

* Updates minimum SDK version to Flutter 3.0.

## 0.3.2+2

* Fixes lints warnings.
Expand Down
2 changes: 1 addition & 1 deletion packages/multicast_dns/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
version: 0.3.2+2

environment:
sdk: ">=2.14.0 <3.0.0"
sdk: ">=2.17.0 <3.0.0"

dependencies:
meta: ^1.3.0
Expand Down
1 change: 1 addition & 0 deletions packages/palette_generator/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ version: 0.1.0

environment:
sdk: ">=2.12.0 <3.0.0"
flutter: ">=3.0.0"

dependencies:
flutter:
Expand Down
1 change: 1 addition & 0 deletions packages/pigeon/mock_handler_tester/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ version: 1.0.0+1

environment:
sdk: ">=2.12.0 <3.0.0"
flutter: ">=3.0.0"

dependencies:
cupertino_icons: ^1.0.2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ publish_to: none # Remove this line if you wish to publish to pub.dev
version: 1.0.0+1
environment:
sdk: ">=2.12.0 <3.0.0"
flutter: ">=3.0.0"

dependencies:
flutter:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ version: 1.0.0+1

environment:
sdk: ">=2.12.0 <3.0.0"
flutter: ">=3.0.0"

dependencies:
cupertino_icons: ^1.0.5
Expand Down
1 change: 1 addition & 0 deletions packages/rfw/example/hello/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ version: 1.0.0+1

environment:
sdk: ">=2.13.0 <3.0.0"
flutter: ">=3.0.0"

dependencies:
flutter:
Expand Down
1 change: 1 addition & 0 deletions packages/rfw/example/local/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ version: 1.0.0+1

environment:
sdk: ">=2.13.0 <3.0.0"
flutter: ">=3.0.0"

dependencies:
flutter:
Expand Down
1 change: 1 addition & 0 deletions packages/rfw/example/remote/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ version: 1.0.0+1

environment:
sdk: ">=2.13.0 <3.0.0"
flutter: ">=3.0.0"

dependencies:
flutter:
Expand Down
1 change: 1 addition & 0 deletions packages/rfw/example/wasm/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ version: 1.0.0+1

environment:
sdk: ">=2.13.0 <3.0.0"
flutter: ">=3.0.0"

dependencies:
flutter:
Expand Down
2 changes: 1 addition & 1 deletion packages/rfw/test_coverage/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ version: 1.0.0
publish_to: none

environment:
sdk: '>=2.14.0 <3.0.0'
sdk: '>=2.17.0 <3.0.0'

dependencies:
lcov_parser: 0.1.1
4 changes: 4 additions & 0 deletions packages/xdg_directories/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## NEXT

* Updates minimum SDK version to Flutter 3.0.

## 0.2.0+3

* Returns null instead of throwing exception from getUserDirectory when xdg-user-dir executable is missing.
Expand Down
2 changes: 1 addition & 1 deletion packages/xdg_directories/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
version: 0.2.0+3

environment:
sdk: ">=2.12.0 <3.0.0"
sdk: ">=2.17.0 <3.0.0"

platforms:
linux:
Expand Down
4 changes: 4 additions & 0 deletions third_party/packages/cupertino_icons/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## NEXT

* Updates minimum SDK version to Flutter 3.0.

## 1.0.5

* Updates README to reference correct URL.
Expand Down
2 changes: 1 addition & 1 deletion third_party/packages/cupertino_icons/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
version: 1.0.5

environment:
sdk: ">=2.12.0 <3.0.0"
sdk: ">=2.17.0 <3.0.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could support arbitrarily old versions here since there's no Dart code, but building special casing in the tool to override the check just to allow new versions of this package to support really old versions of Flutter doesn't seem worthwhile.


flutter:
fonts:
Expand Down