Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Enable min SDK version checks #3095

Merged
merged 7 commits into from
Jan 27, 2023
Merged

[ci] Enable min SDK version checks #3095

merged 7 commits into from
Jan 27, 2023

Conversation

stuartmorgan
Copy link
Contributor

Rolls the repository tools forward to 0.13.4 and enables the new repo checks that no package claims to support an older version than the legacy analyzer tests are validating, since we have no idea if they actually work.

Updates packages as necessary to fix violations (those that didn't have a Flutter SDK constraint at all, since those were caught in the legacy test update).

This deliberately does not update any package versions, since we don't want to actively publish this change, only have it apply to future releases.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan stuartmorgan added the override: no versioning needed Override the check requiring version bumps for most changes label Jan 26, 2023
stuartmorgan
stuartmorgan commented Jan 26, 2023
View reviewed changes
third_party/packages/cupertino_icons/pubspec.yaml
@@ -6,7 +6,7 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
version: 1.0.5

environment:
sdk: ">=2.12.0 <3.0.0"
sdk: ">=2.17.0 <3.0.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could support arbitrarily old versions here since there's no Dart code, but building special casing in the tool to override the check just to allow new versions of this package to support really old versions of Flutter doesn't seem worthwhile.

@tarrinneal
Copy link
Contributor

You've angered the analyzer and repo check gods

@stuartmorgan
Copy link
Contributor Author

You've angered the analyzer and repo check gods

pigeon and rfw are expected false-positives, I just didn't put the override label on at first to make sure nothing else turned up (although in retrospect I could have just run it locally). The flutter_lint one is just a misake; fix coming shortly.

@stuartmorgan stuartmorgan added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Jan 26, 2023
@stuartmorgan
Copy link
Contributor Author

Oh nice, we can use super. in flutter/plugins and flutter/packages now! I thought that was still another stable cycle away.

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 26, 2023
@stuartmorgan stuartmorgan removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 26, 2023
@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 27, 2023
@auto-submit auto-submit bot merged commit b1a7162 into flutter:main Jan 27, 2023
sybrands-place pushed a commit to sybrands-place/packages that referenced this pull request Jan 30, 2023
Merge branch 'main' into null_status_retriable
577bbb1 
* main: (479 commits)
  removes raw ArrayLists (flutter#3101)
  Roll Flutter from c9affdb to 27f8ebd (15 revisions) (flutter#3098)
  [ci] Fix the new LUCI iOS build-all tasks (flutter#3099)
  [pigeon] [ObjC] Removes unused GetNullableObject function (flutter#3100)
  [pigeon] Swift host error handling (flutter#3084)
  Roll Flutter from a815ee6 to c9affdb (23 revisions) (flutter#3093)
  [ci] Enable min SDK version checks (flutter#3095)
  [pigeon] Fix C++ config handling (flutter#3094)
  [ci] Add LUCI version of iOS build-all (flutter#3096)
  [pigeon] Adds SwiftFunction annotation (flutter#2304)
  [flutter_adaptive_scaffold] Change `selectedIndex` on `standardNavigationRail` to allow null value. (flutter#3088)
  [pigeon] requires analyzer 5.2.0 (flutter#3090)
  Roll Flutter from c35efda to a815ee6 (22 revisions) (flutter#3089)
  [ci] Update legacy Flutter version tests (flutter#3087)
  Roll Flutter (stable) from 135454af3247 to b06b8b271095 (2551 revisions) (flutter#3086)
  [flutter_adaptive_scaffold] Fix leading and trailing Navigation Rail Widgets (flutter#3080)
  Roll Flutter from bd7bee0 to c35efda (24 revisions) (flutter#3085)
  [pigeon] Minor C++ output adjustments (flutter#3083)
  [pigeon] Updates writeScoped and addScoped to disallow symbol-less use. (flutter#3081)
  Roll Flutter from f33e8d3 to bd7bee0 (5 revisions) (flutter#3082)
  ...
@stuartmorgan stuartmorgan mentioned this pull request Jan 31, 2023
Merged
11 tasks
@stuartmorgan stuartmorgan deleted the enable-min-version-checks branch February 1, 2023 12:57
auto-submit bot pushed a commit that referenced this pull request Feb 1, 2023
@stuartmorgan
[cross_file] Fix accidental constructor change (#3131)
ff89d92 
* [cross_file] Fix accidental constructor change

In #3095 I accidentally changed
a constructor argument's nullability because of a misleading analyzer
warning. That version has been retracted; this restores the original
behavior.

* Add a test

* Better implementation
Maatteogekko pushed a commit to Maatteogekko/packages that referenced this pull request Feb 4, 2023
@stuartmorgan @Maatteogekko
[ci] Enable min SDK version checks (flutter#3095)
bca7001 
* Roll tool version

* Enable new check in CI

* Fix violations

* CHANGELOG updates

* Fix changelog

* Address analyzer issues

* Revert flutter_lints changelog
Maatteogekko pushed a commit to Maatteogekko/packages that referenced this pull request Feb 4, 2023
@stuartmorgan @Maatteogekko
[cross_file] Fix accidental constructor change (flutter#3131)
8497767 
* [cross_file] Fix accidental constructor change

In flutter#3095 I accidentally changed
a constructor argument's nullability because of a misleading analyzer
warning. That version has been retracted; this restores the original
behavior.

* Add a test

* Better implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer left review comments

@jmagman jmagman jmagman approved these changes

@Hixie Hixie Awaiting requested review from Hixie Hixie is a code owner

@tarrinneal tarrinneal Awaiting requested review from tarrinneal tarrinneal is a code owner

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

@gspencergoog gspencergoog Awaiting requested review from gspencergoog gspencergoog is a code owner

@dnfield dnfield Awaiting requested review from dnfield

@keyonghan keyonghan Awaiting requested review from keyonghan

@ditman ditman Awaiting requested review from ditman ditman is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: animations p: cross_file p: cupertino_icons p: flutter_lints p: flutter_template_images p: metrics_center p: multicast_dns p: palette_generator p: pigeon p: rfw Remote Flutter Widgets p: xdg_directories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stuartmorgan @tarrinneal @jmagman @goderbauer