Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fix the new LUCI iOS build-all tasks #3099

Merged
merged 1 commit into from
Jan 28, 2023

Conversation

stuartmorgan
Copy link
Contributor

Corrects the name of the tasks; they accidentally used the old "plugins" name rather than the new generic "packages" name that we're moving to for anything that is not actually plugin-specific.

Also fixes the script referenced in the build step.

Corrects the name of the tasks; they accidentally used the old "plugins"
name rather than the new generic "packages" name that we're moving to
for anything that is not actually plugin-specific.

Also fixes the script referenced in the build step.
@stuartmorgan
Copy link
Contributor Author

Unfortunately since the name was wrong, and changing the name makes it a "new" task, I have to do another PR cycle before bringing it out of bringup mode :(

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 27, 2023
@auto-submit auto-submit bot merged commit e934db8 into flutter:main Jan 28, 2023
@stuartmorgan stuartmorgan deleted the ci-luci-ios-build-all-fixes branch January 28, 2023 03:51
sybrands-place pushed a commit to sybrands-place/packages that referenced this pull request Jan 30, 2023
* main: (479 commits)
  removes raw ArrayLists (flutter#3101)
  Roll Flutter from c9affdb to 27f8ebd (15 revisions) (flutter#3098)
  [ci] Fix the new LUCI iOS build-all tasks (flutter#3099)
  [pigeon] [ObjC] Removes unused GetNullableObject function (flutter#3100)
  [pigeon] Swift host error handling (flutter#3084)
  Roll Flutter from a815ee6 to c9affdb (23 revisions) (flutter#3093)
  [ci] Enable min SDK version checks (flutter#3095)
  [pigeon] Fix C++ config handling (flutter#3094)
  [ci] Add LUCI version of iOS build-all (flutter#3096)
  [pigeon] Adds SwiftFunction annotation (flutter#2304)
  [flutter_adaptive_scaffold] Change `selectedIndex` on `standardNavigationRail` to allow null value. (flutter#3088)
  [pigeon] requires analyzer 5.2.0 (flutter#3090)
  Roll Flutter from c35efda to a815ee6 (22 revisions) (flutter#3089)
  [ci] Update legacy Flutter version tests (flutter#3087)
  Roll Flutter (stable) from 135454af3247 to b06b8b271095 (2551 revisions) (flutter#3086)
  [flutter_adaptive_scaffold] Fix leading and trailing Navigation Rail Widgets (flutter#3080)
  Roll Flutter from bd7bee0 to c35efda (24 revisions) (flutter#3085)
  [pigeon] Minor C++ output adjustments (flutter#3083)
  [pigeon] Updates writeScoped and addScoped to disallow symbol-less use. (flutter#3081)
  Roll Flutter from f33e8d3 to bd7bee0 (5 revisions) (flutter#3082)
  ...
Maatteogekko pushed a commit to Maatteogekko/packages that referenced this pull request Feb 4, 2023
Corrects the name of the tasks; they accidentally used the old "plugins"
name rather than the new generic "packages" name that we're moving to
for anything that is not actually plugin-specific.

Also fixes the script referenced in the build step.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants