[webview_flutter] Implement platform interface for JavaScript dialog #5670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsharp83
force-pushed
the
platform-interface-for-javascript-panel
branch
from
645d289
to
d1ae610
Compare
stuartmorgan
approved these changes
Dec 14, 2023
| /// Message to be displayed in the window. | ||
| final String message; | ||
|
|
||
| /// The url of the page requesting the dialog. |
There was a problem hiding this comment.
Nit: URL
(In comments it should be capitalized normally, rather than as code.)
| /// Message to be displayed in the window. | ||
| final String message; | ||
|
|
||
| /// The url of the page requesting the dialog. |
| /// Message to be displayed in the window. | ||
| final String message; | ||
|
|
||
| /// The url of the page requesting the dialog. |
| required this.url, | ||
| }); | ||
|
|
||
| /// Message to be displayed in the window. |
There was a problem hiding this comment.
Nit: The message [...]
(To be consistent with the other comments.)
| required this.url, | ||
| }); | ||
|
|
||
| /// Message to be displayed in the window. |
| required this.defaultText, | ||
| }); | ||
|
|
||
| /// Message to be displayed in the window. |
jsharp83
force-pushed
the
platform-interface-for-javascript-panel
branch
from
ca18ce9
to
b535b22
Compare
jsharp83
force-pushed
the
platform-interface-for-javascript-panel
branch
from
88c04ee
to
68bed91
Compare
|
@bparrishMines Can you check this PR? Thanks |
bparrishMines
added
the
autosubmit
11 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 20, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 20, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 20, 2023
flutter/packages@be52ac8...dc5b267 2023-12-20 [email protected] Roll Flutter from 0eb7881 to da0cd69 (15 revisions) (flutter/packages#5729) 2023-12-20 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#5702) 2023-12-19 [email protected] [webview_flutter] Implement platform interface for JavaScript dialog (flutter/packages#5670) 2023-12-19 [email protected] [webview_flutter] Support for handling basic authentication requests (iOS) (flutter/packages#5455) 2023-12-19 [email protected] Roll Flutter from cdc83e5 to 0eb7881 (17 revisions) (flutter/packages#5722) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ChopinDavid
pushed a commit
to wwt/flutter-packages
that referenced
this pull request
Dec 28, 2023
…lutter#5670) Adds the platform interface implementation for JavaScript dailog. This PR is part of a series of PRs that aim to close flutter/flutter#30358 (comment) The PR that contains all changes can be found at flutter#4704
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this pull request
Dec 28, 2023
flutter/packages@be52ac8...dc5b267 2023-12-20 [email protected] Roll Flutter from 0eb7881 to da0cd69 (15 revisions) (flutter/packages#5729) 2023-12-20 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#5702) 2023-12-19 [email protected] [webview_flutter] Implement platform interface for JavaScript dialog (flutter/packages#5670) 2023-12-19 [email protected] [webview_flutter] Support for handling basic authentication requests (iOS) (flutter/packages#5455) 2023-12-19 [email protected] Roll Flutter from cdc83e5 to 0eb7881 (17 revisions) (flutter/packages#5722) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
…iew (#5795) * There are cases where Web calls System Popup with javascript on webview_flutter * At this time, the message comes in the WKUIDelegate part in iOS. * https://developer.apple.com/documentation/webkit/wkuidelegate/1537406-webview * https://developer.apple.com/documentation/webkit/wkuidelegate/1536489-webview * Related issue: flutter/flutter#30358 (comment) * Related Interface PR: #5670 * The PR that contains all changes can be found at #4704
12 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
…5796) * There are cases where Web calls System Popup with javascript on webview_flutter * Android has a interface on WebChromeClient * https://developer.android.com/reference/android/webkit/WebChromeClient#onJsAlert(android.webkit.WebView,%20java.lang.String,%20java.lang.String,%20android.webkit.JsResult) * Related issue: flutter/flutter#30358 (comment) * Related Interface PR: #5670 * The PR that contains all changes can be found at #4704
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
…#4704) * there are cases where Web calls System Popup with javascript on webview_flutter * At this time, the message comes in the WKUIDelegate part in iOS. * https://developer.apple.com/documentation/webkit/wkuidelegate/1537406-webview * https://developer.apple.com/documentation/webkit/wkuidelegate/1536489-webview * Android also has a interface on WebChromeClient * https://developer.android.com/reference/android/webkit/WebChromeClient#onJsAlert(android.webkit.WebView,%20java.lang.String,%20java.lang.String,%20android.webkit.JsResult) * It was implemented according to the requirements of the code review of the #4555 * Related issue: flutter/flutter#30358 (comment) * Related Interface PR: #5670
16 tasks
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…lutter#5670) Adds the platform interface implementation for JavaScript dailog. This PR is part of a series of PRs that aim to close flutter/flutter#30358 (comment) The PR that contains all changes can be found at flutter#4704
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…iew (flutter#5795) * There are cases where Web calls System Popup with javascript on webview_flutter * At this time, the message comes in the WKUIDelegate part in iOS. * https://developer.apple.com/documentation/webkit/wkuidelegate/1537406-webview * https://developer.apple.com/documentation/webkit/wkuidelegate/1536489-webview * Related issue: flutter/flutter#30358 (comment) * Related Interface PR: flutter#5670 * The PR that contains all changes can be found at flutter#4704
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…lutter#5796) * There are cases where Web calls System Popup with javascript on webview_flutter * Android has a interface on WebChromeClient * https://developer.android.com/reference/android/webkit/WebChromeClient#onJsAlert(android.webkit.WebView,%20java.lang.String,%20java.lang.String,%20android.webkit.JsResult) * Related issue: flutter/flutter#30358 (comment) * Related Interface PR: flutter#5670 * The PR that contains all changes can be found at flutter#4704
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…flutter#4704) * there are cases where Web calls System Popup with javascript on webview_flutter * At this time, the message comes in the WKUIDelegate part in iOS. * https://developer.apple.com/documentation/webkit/wkuidelegate/1537406-webview * https://developer.apple.com/documentation/webkit/wkuidelegate/1536489-webview * Android also has a interface on WebChromeClient * https://developer.android.com/reference/android/webkit/WebChromeClient#onJsAlert(android.webkit.WebView,%20java.lang.String,%20java.lang.String,%20android.webkit.JsResult) * It was implemented according to the requirements of the code review of the flutter#4555 * Related issue: flutter/flutter#30358 (comment) * Related Interface PR: flutter#5670
bill-skdnd
pushed a commit
to skdnd-metaspace/webview_flutter_wkwebview
that referenced
this pull request
Aug 2, 2024
…iew (#5795) * There are cases where Web calls System Popup with javascript on webview_flutter * At this time, the message comes in the WKUIDelegate part in iOS. * https://developer.apple.com/documentation/webkit/wkuidelegate/1537406-webview * https://developer.apple.com/documentation/webkit/wkuidelegate/1536489-webview * Related issue: flutter/flutter#30358 (comment) * Related Interface PR: flutter/packages#5670 * The PR that contains all changes can be found at flutter/packages#4704
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the platform interface implementation for JavaScript dailog.
This PR is part of a series of PRs that aim to close flutter/flutter#30358 (comment)
The PR that contains all changes can be found at #4704
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.