[webview_flutter] Support for handling basic authentication requests (iOS) #5455

JeroenWeener · 2023-11-21T11:55:17Z

Adds the iOS implementation for basic http authentication.

This PR is part of a series of PRs that aim to close flutter/flutter#83556.
The PR that contains all changes can be found at #4140.

Pre-launch Checklist

…/packages into webview-auth-request

…b/src/types/http_auth_request.dart

…request

…s into webview-auth-request

bparrishMines

Everything looks good. Just need to update the pubspecs

bparrishMines · 2023-11-28T00:54:54Z

packages/webview_flutter/webview_flutter_wkwebview/example/pubspec.yaml

+
+# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.
+# See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins
+dependency_overrides:
+   {webview_flutter_platform_interface: {path: ../../../webview_flutter/webview_flutter_platform_interface}}


Remove this and update the minimum webview_flutter_platform_interface to ^2.7.0

Suggested change

# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.

# See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins

dependency_overrides:

{webview_flutter_platform_interface: {path: ../../../webview_flutter/webview_flutter_platform_interface}}

bparrishMines · 2023-11-28T00:55:32Z

packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml

+
+# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.
+# See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins
+dependency_overrides:
+   {webview_flutter_platform_interface: {path: ../../webview_flutter/webview_flutter_platform_interface}}


Same for this

Suggested change

# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.

# See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins

dependency_overrides:

{webview_flutter_platform_interface: {path: ../../webview_flutter/webview_flutter_platform_interface}}

…as06/packages into webview-auth-request-ios

bparrishMines

LGTM

@stuartmorgan for secondary review

stuartmorgan

LGTM with one question.

stuartmorgan · 2023-11-29T18:24:51Z

packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FWFNavigationDelegateHostApi.m

+                                         challenge:challenge
+                                        completion:^(FWFAuthenticationChallengeResponse *response,
+                                                     FlutterError *error) {
+                                          NSAssert(!error, @"%@", error);


Why is this an assert? Couldn't a plugin client have an implementation on the Dart side that throws an exception, leading to a FlutterError here?

This is a pattern I started with all the FlutterApi methods. IIRC when there is an exception thrown on the Dart side during a FlutterApi method, this error is returned and it wouldn't be printed anywhere. Essentially failing silently. This would catch the error and print it to the console when the app is not in release mode or disabling asserts. It's mainly to help with debugging.

At the very least, this used to be the case on Android.

Right, but in most cases I thought it was just calling our own code, so we could reasonably assert that an error didn't exist.

I guess the question here is: if a plugin client throws an exception in their own Dart code that implements the handler, do we want the entire application to crash?

@bparrishMines Should we adjust this, or land as-is and revisit later if necessary?

I created flutter/flutter#140410 to track the discussion. I think we could probably find a better alternative, but I haven't seen any issues raised by users.

…equests (iOS) (flutter/packages#5455)

flutter/packages@be52ac8...dc5b267 2023-12-20 [email protected] Roll Flutter from 0eb7881 to da0cd69 (15 revisions) (flutter/packages#5729) 2023-12-20 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#5702) 2023-12-19 [email protected] [webview_flutter] Implement platform interface for JavaScript dialog (flutter/packages#5670) 2023-12-19 [email protected] [webview_flutter] Support for handling basic authentication requests (iOS) (flutter/packages#5455) 2023-12-19 [email protected] Roll Flutter from cdc83e5 to 0eb7881 (17 revisions) (flutter/packages#5722) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…(iOS) (flutter#5455) Adds the iOS implementation for basic http authentication. This PR is part of a series of PRs that aim to close flutter/flutter#83556. The PR that contains all changes can be found at flutter#4140.

flutter/packages@be52ac8...dc5b267 2023-12-20 [email protected] Roll Flutter from 0eb7881 to da0cd69 (15 revisions) (flutter/packages#5729) 2023-12-20 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#5702) 2023-12-19 [email protected] [webview_flutter] Implement platform interface for JavaScript dialog (flutter/packages#5670) 2023-12-19 [email protected] [webview_flutter] Support for handling basic authentication requests (iOS) (flutter/packages#5455) 2023-12-19 [email protected] Roll Flutter from cdc83e5 to 0eb7881 (17 revisions) (flutter/packages#5722) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…5727) ## Description This pull request exposes the Android and iOS HTTP Basic Authentication feature to users of the `webview_flutter` plugin. It is the final PR in a sequence of PRs. Previous PRs are #5362, #5454 and #5455. Issues fixed by PR: Closes flutter/flutter#83556

…(iOS) (flutter#5455) Adds the iOS implementation for basic http authentication. This PR is part of a series of PRs that aim to close flutter/flutter#83556. The PR that contains all changes can be found at flutter#4140.

…lutter#5727) ## Description This pull request exposes the Android and iOS HTTP Basic Authentication feature to users of the `webview_flutter` plugin. It is the final PR in a sequence of PRs. Previous PRs are flutter#5362, flutter#5454 and flutter#5455. Issues fixed by PR: Closes flutter/flutter#83556

JeroenWeener and others added 30 commits October 26, 2023 11:23

Implement http basic auth

517e9d4

Apply feedback

967879b

Create HttpAuthHandlerTest.java

c8624c0

Format java files

4f3574d

Regenerate build_runner files

1e7f785

Implement feedback

131bc56

Remove redundant key in Info.plist

bc01be4

Update example apps

67aa00e

Implement http basic auth

32496d0

Apply feedback

aeb8708

Create HttpAuthHandlerTest.java

fffc4c7

Format java files

b455040

Regenerate build_runner files

2aa9bfe

Implement feedback

db286ba

Remove redundant key in Info.plist

467feb3

Update example apps

dad8ae6

Merge branch 'webview-auth-request' of https://github.com/andreisas06…

6f3d802

…/packages into webview-auth-request

Add platform interface dev dependency to example

0fef591

Merge branch 'main' into webview-auth-request

b2a4fbb

Update packages/webview_flutter/webview_flutter_platform_interface/li…

ce35d9b

…b/src/types/http_auth_request.dart

Merge branch 'main' of github.com:flutter/packages into webview-auth-…

fc32898

…request

Merge branch 'webview-auth-request' of github.com:andreisas06/package…

4673e65

…s into webview-auth-request

Fix some lints, errros and call on errors

580521a

fix lints

d1f305b

fix tests

a3f74be

add onProceed and onCancel back

ed3798f

dont require realm to be nonnull

154c1f8

add line back

3c61dbc

Merge remote-tracking branch 'upstream/main' into webview-auth-request

7cf0d7e

Update changelogs

a21f29a

github-actions bot removed the platform-android label Nov 21, 2023

JeroenWeener marked this pull request as ready for review November 21, 2023 11:57

JeroenWeener requested a review from hellohuanlin as a code owner November 21, 2023 11:57

bparrishMines self-requested a review November 28, 2023 00:53

bparrishMines requested changes Nov 28, 2023

View reviewed changes

JeroenWeener added 2 commits November 28, 2023 09:36

Update pubspecs

3ccf157

Merge branch 'webview-auth-request-ios' of https://github.com/andreis…

d0d4926

…as06/packages into webview-auth-request-ios

JeroenWeener requested a review from bparrishMines November 28, 2023 08:39

bparrishMines approved these changes Nov 29, 2023

View reviewed changes

stuartmorgan approved these changes Nov 29, 2023

View reviewed changes

bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 19, 2023

auto-submit bot merged commit 3273017 into flutter:main Dec 19, 2023
80 checks passed

bparrishMines mentioned this pull request Dec 19, 2023

[webview_flutter_wkwebview] Callback methods shouldn't assert error is null flutter/flutter#140410

Open

JeroenWeener mentioned this pull request Dec 20, 2023

[webview_flutter] Support for handling basic authentication requests #5727

Merged

11 tasks

engine-flutter-autoroll mentioned this pull request Dec 20, 2023

Roll Packages from be52ac86bb4f to a38446ddf905 (4 revisions) flutter/flutter#140449

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2023

3273017 [webview_flutter] Support for handling basic authentication r…

279a3d3

…equests (iOS) (flutter/packages#5455)

engine-flutter-autoroll mentioned this pull request Dec 20, 2023

Roll Packages from be52ac86bb4f to dc5b267f3cd1 (5 revisions) flutter/flutter#140450

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2023

3273017 [webview_flutter] Support for handling basic authentication r…

910241d

…equests (iOS) (flutter/packages#5455)

reidbaker mentioned this pull request Jan 12, 2024

Dialog Debug #5881

Closed

reidbaker mentioned this pull request Jan 19, 2024

[in_app_purchase] Add play country code api #5941

Merged

12 tasks

reidbaker mentioned this pull request Feb 19, 2024

[in_app_purchase_android] Add UserChoiceBilling mode. #6162

Merged

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[webview_flutter] Support for handling basic authentication requests (iOS) #5455

[webview_flutter] Support for handling basic authentication requests (iOS) #5455

JeroenWeener commented Nov 21, 2023

bparrishMines left a comment

bparrishMines Nov 28, 2023

bparrishMines Nov 28, 2023

bparrishMines left a comment

stuartmorgan left a comment

stuartmorgan Nov 29, 2023

bparrishMines Nov 30, 2023 •

edited

Loading

stuartmorgan Nov 30, 2023

stuartmorgan Dec 13, 2023

bparrishMines Dec 19, 2023

[webview_flutter] Support for handling basic authentication requests (iOS) #5455

[webview_flutter] Support for handling basic authentication requests (iOS) #5455

Conversation

JeroenWeener commented Nov 21, 2023

Pre-launch Checklist

bparrishMines left a comment

Choose a reason for hiding this comment

bparrishMines Nov 28, 2023

Choose a reason for hiding this comment

bparrishMines Nov 28, 2023

Choose a reason for hiding this comment

bparrishMines left a comment

Choose a reason for hiding this comment

stuartmorgan left a comment

Choose a reason for hiding this comment

stuartmorgan Nov 29, 2023

Choose a reason for hiding this comment

bparrishMines Nov 30, 2023 • edited Loading

Choose a reason for hiding this comment

stuartmorgan Nov 30, 2023

Choose a reason for hiding this comment

stuartmorgan Dec 13, 2023

Choose a reason for hiding this comment

bparrishMines Dec 19, 2023

Choose a reason for hiding this comment

bparrishMines Nov 30, 2023 •

edited

Loading