[web] Updates package:web dependency to ^0.5.0. #5791

kevmoo · 2024-01-03T22:28:03Z

This PR updates the packages that are using package:web to version ^0.5.0.

Ancilliary changes:

Bump environment to flutter: ">=3.19.0" and sdk: ^3.3.0.
Bump version to next Y
Clean-up code that was kept for compatibility with versions of web: <0.5.0.

The main exception to this is package:google_sign_in_web, which depends on a version of google_identity_services_web that has a dependency on package:web that is <0.5.0, so that package needs to have a range until google_identity_services_web gets published with the new ^0.5.0 dependency.

Co-Authored-By: @ditman

packages/web_benchmarks/lib/client.dart

ditman · 2024-02-16T18:52:03Z

I'll take over landing this one!

ditman · 2024-02-16T23:30:18Z

$ grep js_util * -Irn | grep "_web" | grep "dart:" | cut -d: -f1 | sort | uniq -c | sort -r
      5 camera/camera_web/example/integration_test/camera_service_test.dart
      4 camera/camera_web/lib/src/shims/dart_js_util.dart
      3 camera/camera_web/lib/src/camera_service.dart
      1 google_maps_flutter/google_maps_flutter_web/lib/google_maps_flutter_web.dart
      1 google_maps_flutter/google_maps_flutter_web/example/integration_test/google_maps_plugin_test.dart
      1 camera/camera_web/example/integration_test/helpers/mocks.dart

js_util seems to be almost gone from the repo (except from known non-migrated packages)

ditman · 2024-02-17T02:40:46Z

I think this is OK now. PTAL @stuartmorgan (and @kevmoo)!

kevmoo · 2024-02-17T02:43:41Z

I'd review it if I could! Thanks @ditman

packages/google_identity_services_web/lib/src/js_interop/package_web_tweaks.dart

packages/google_sign_in/google_sign_in_web/CHANGELOG.md

stuartmorgan · 2024-02-20T16:12:26Z

packages/google_sign_in/google_sign_in_web/pubspec.yaml

@@ -25,7 +25,7 @@ dependencies:
  google_identity_services_web: ^0.3.0
  google_sign_in_platform_interface: ^2.4.0
  http: ">=0.13.0 <2.0.0"
-  web: ">=0.3.0 <0.5.0"
+  web: ">=0.3.0 <0.6.0" # because google_identity_services


Is this comment explaining the lower limit or the upper limit? More details would help.

I think this is because google_identity_services has not been upgraded yet...

The comment explains the upper limit, this is the package I'll immediately update after landing this PR, so the upper limit will live there only for one small publish.

packages/metrics_center/pubspec.yaml

packages/video_player/video_player_web/example/integration_test/utils.dart

stuartmorgan

LGTM modulo the changelog nits

ditman · 2024-02-20T21:43:50Z

Applying autosubmit 🤞

This PR updates `google_sign_in_web` to use package `web: ^0.5.0`. ## Testing Manually verified using the `example/lib/button_tester.dart` app. This should be text exempt? This is a refactor with no semantic change (also, I wouldn't know how to test we're using `package:web` the expected way!) I removed a couple of `//ignore` at least! ## Issues * Fast follow of: #5791

…ages#5791)

flutter/packages@8bba41b...48048f6 2024-02-20 [email protected] [google_sign_in_web] Updates package:web dependency to 0.5.0. (flutter/packages#6167) 2024-02-20 [email protected] [web] Updates package:web dependency to ^0.5.0. (flutter/packages#5791) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This PR updates the packages that are using `package:web` to version `^0.5.0`. Ancilliary changes: * Bump `environment` to `flutter: ">=3.19.0"` and `sdk: ^3.3.0`. * Bump version to next `Y` * Clean-up code that was kept for compatibility with versions of `web: <0.5.0`. The main exception to this is `package:google_sign_in_web`, which depends on a version of `google_identity_services_web` that has a dependency on package:web that is `<0.5.0`, so that package needs to have a range until `google_identity_services_web` gets published with the new ^0.5.0 dependency. Co-Authored-By: David Iglesias<[email protected]>

…r#6167) This PR updates `google_sign_in_web` to use package `web: ^0.5.0`. ## Testing Manually verified using the `example/lib/button_tester.dart` app. This should be text exempt? This is a refactor with no semantic change (also, I wouldn't know how to test we're using `package:web` the expected way!) I removed a couple of `//ignore` at least! ## Issues * Fast follow of: flutter#5791

github-actions bot added platform-web p: url_launcher labels Jan 3, 2024

kevmoo force-pushed the url_launcher_web_drop_js_util branch 2 times, most recently from 3e5c823 to 1fae6fe Compare January 9, 2024 21:17

kevmoo changed the title ~~WIP: drop dart:js_util, require Dart 3.3~~ [url_launcher_web] WIP: drop dart:js_util, require Dart 3.3 Jan 17, 2024

kevmoo force-pushed the url_launcher_web_drop_js_util branch from f28a73c to f61d8c7 Compare January 17, 2024 18:22

kevmoo force-pushed the url_launcher_web_drop_js_util branch from f61d8c7 to 2b99c89 Compare February 5, 2024 23:32

kevmoo force-pushed the url_launcher_web_drop_js_util branch from 2b99c89 to cbc80ed Compare February 13, 2024 20:30

github-actions bot added the p: shared_preferences label Feb 13, 2024

kevmoo changed the title ~~[url_launcher_web] WIP: drop dart:js_util, require Dart 3.3~~ [url_launcher_web] drop dart:js_util, require Dart 3.3 Feb 13, 2024

github-actions bot added p: web_benchmarks p: pointer_interceptor labels Feb 13, 2024

kevmoo force-pushed the url_launcher_web_drop_js_util branch from a9c9910 to c7f71f2 Compare February 15, 2024 20:07

github-actions bot added p: cross_file p: file_selector p: google_sign_in labels Feb 15, 2024

stuartmorgan added the waiting for stable update Can't be landed until functionality reaches the stable channel label Feb 15, 2024

github-actions bot added the p: metrics_center label Feb 15, 2024

kevmoo force-pushed the url_launcher_web_drop_js_util branch from 7bf1cef to 70859ab Compare February 15, 2024 21:03

github-actions bot added p: image_picker p: video_player labels Feb 15, 2024

kevmoo force-pushed the url_launcher_web_drop_js_util branch from 7c97874 to 66ca672 Compare February 15, 2024 22:36

stuartmorgan removed the waiting for stable update Can't be landed until functionality reaches the stable channel label Feb 16, 2024

stuartmorgan reviewed Feb 16, 2024

View reviewed changes

packages/web_benchmarks/lib/client.dart Outdated Show resolved Hide resolved

kevmoo added 4 commits February 16, 2024 11:16

WIP: drop dart:js_util, require Dart 3.3

0be61a0

more silly

3c9131c

update mocks

2d3d123

fix sdk versions

735f84b

ditman force-pushed the url_launcher_web_drop_js_util branch from 66ca672 to 735f84b Compare February 16, 2024 19:24

kevmoo requested a review from keyonghan as a code owner February 16, 2024 22:45

[video_player_web] Fix js-interop test utils.

bdfc7c5

ditman changed the title ~~[web] Update web packages to Dart 3.3, Flutter 3.19, and web: ^0.5.0 (or <0.6.0)~~ [web] Updates package:web dependency to ^0.5.0. Feb 16, 2024

ditman added 2 commits February 16, 2024 15:37

Fixes "Updates to web code to" -> "Updates web code to"

153295b

Minimize c-p from package:web.

4508a43

This comment was marked as outdated.

Sign in to view

ditman added 4 commits February 16, 2024 17:05

Bring back nullableTrustedTypes.

271af3c

Clean up some stuff from web 0.3

986fe5c

[file_selector_web] cleanup web < 0.5.0

ba4137d

[gis_web] Clean up web < 0.5.0

f347c67

ditman requested a review from stuartmorgan February 17, 2024 02:40

stuartmorgan reviewed Feb 20, 2024

View reviewed changes

stuartmorgan approved these changes Feb 20, 2024

View reviewed changes

ditman added 2 commits February 20, 2024 13:37

metrics_center update googleapis to 12.0.0+

204d1f9

google_sign_in_web updates README. Bumps z version.

09ff845

ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 20, 2024

auto-submit bot merged commit b21dce5 into flutter:main Feb 20, 2024
78 checks passed

kevmoo deleted the url_launcher_web_drop_js_util branch February 20, 2024 22:03

ditman mentioned this pull request Feb 20, 2024

[google_sign_in_web] Updates package:web dependency to 0.5.0. #6167

Merged

11 tasks

engine-flutter-autoroll mentioned this pull request Feb 21, 2024

Roll Packages from 8bba41b0c046 to 48048f6bc779 (2 revisions) flutter/flutter#143853

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 21, 2024

b21dce5 [web] Updates package:web dependency to ^0.5.0. (flutter/pack…

32cbf74

…ages#5791)

reidbaker mentioned this pull request Apr 1, 2024

[camera_android_camerax] Move integration_test dependency to tests reidbaker/packages#4

Closed

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[web] Updates package:web dependency to ^0.5.0. #5791

[web] Updates package:web dependency to ^0.5.0. #5791

kevmoo commented Jan 3, 2024 •

edited by ditman

Loading

ditman commented Feb 16, 2024

ditman commented Feb 16, 2024

This comment was marked as outdated.

ditman commented Feb 17, 2024

kevmoo commented Feb 17, 2024

stuartmorgan Feb 20, 2024

kevmoo Feb 20, 2024

ditman Feb 20, 2024

stuartmorgan left a comment

ditman commented Feb 20, 2024

[web] Updates package:web dependency to ^0.5.0. #5791

[web] Updates package:web dependency to ^0.5.0. #5791

Conversation

kevmoo commented Jan 3, 2024 • edited by ditman Loading

ditman commented Feb 16, 2024

ditman commented Feb 16, 2024

This comment was marked as outdated.

ditman commented Feb 17, 2024

kevmoo commented Feb 17, 2024

stuartmorgan Feb 20, 2024

Choose a reason for hiding this comment

kevmoo Feb 20, 2024

Choose a reason for hiding this comment

ditman Feb 20, 2024

Choose a reason for hiding this comment

stuartmorgan left a comment

Choose a reason for hiding this comment

ditman commented Feb 20, 2024

kevmoo commented Jan 3, 2024 •

edited by ditman

Loading