Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google_sign_in_web] Updates package:web dependency to 0.5.0. #6167

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

ditman
Copy link
Member

@ditman ditman commented Feb 20, 2024

This PR updates google_sign_in_web to use package web: ^0.5.0.

Testing

Manually verified using the example/lib/button_tester.dart app.

This should be text exempt? This is a refactor with no semantic change (also, I wouldn't know how to test we're using package:web the expected way!) I removed a couple of //ignore at least!

Issues

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@ditman ditman changed the title [google_sign_in_web] Updates package:web to 0.5.0. [google_sign_in_web] Updates package:web dependency to 0.5.0. Feb 20, 2024
@ditman
Copy link
Member Author

ditman commented Feb 20, 2024

Bot, I think this should be text-exempt. This is my reasoning:

This is a refactor with no semantic change (also, I wouldn't know how to test we're using package:web the expected way!) I removed a couple of //ignore at least!

@matanlurey
Copy link
Contributor

test-exempt: non-semantic refactor.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 20, 2024
@auto-submit auto-submit bot merged commit 48048f6 into flutter:main Feb 20, 2024
78 checks passed
@ditman ditman deleted the bump-package-web-gsi branch February 20, 2024 23:46
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 21, 2024
flutter/packages@8bba41b...48048f6

2024-02-20 [email protected] [google_sign_in_web] Updates package:web dependency to 0.5.0. (flutter/packages#6167)
2024-02-20 [email protected] [web] Updates package:web dependency to ^0.5.0. (flutter/packages#5791)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
…r#6167)

This PR updates `google_sign_in_web` to use package `web: ^0.5.0`.

## Testing

Manually verified using the `example/lib/button_tester.dart` app.

This should be text exempt? This is a refactor with no semantic change (also, I wouldn't know how to test we're using `package:web` the expected way!) I removed a couple of `//ignore` at least!

## Issues

* Fast follow of: flutter#5791
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: google_sign_in platform-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants