-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the emulator versions and expose cipd. #6025
Merged
auto-submit
merged 6 commits into
flutter:main
from
ricardoamador:use_proto_name_emulator
Feb 1, 2024
Merged
Update the emulator versions and expose cipd. #6025
auto-submit
merged 6 commits into
flutter:main
from
ricardoamador:use_proto_name_emulator
Feb 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyonghan
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
stuartmorgan
reviewed
Feb 1, 2024
ricardoamador
force-pushed
the
use_proto_name_emulator
branch
from
February 1, 2024 18:54
1d8785f
to
d611101
Compare
…stead of each target.
ricardoamador
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Feb 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 2, 2024
flutter/packages@5b48c44...d37fb0a 2024-02-02 [email protected] Add a link the different possible Android virtual device configs (flutter/packages#6033) 2024-02-01 [email protected] Update the emulator versions and expose cipd. (flutter/packages#6025) 2024-02-01 [email protected] [tool] Add details to missing gradle coverage error (flutter/packages#6029) 2024-02-01 [email protected] [file_selector] Fix comment typo (flutter/packages#6027) 2024-02-01 [email protected] [camerax] Change `buildPreview` to return `Texture` versus `FutureBuilder` (flutter/packages#6021) 2024-02-01 [email protected] Manual roll Flutter from c65ab4d to e02e207 (38 revisions) (flutter/packages#6028) 2024-02-01 [email protected] Manual roll Flutter from 75a2e5b to c65ab4d (22 revisions) (flutter/packages#6026) 2024-02-01 [email protected] Roll Flutter from ace9181 to 75a2e5b (16 revisions) (flutter/packages#6017) 2024-02-01 [email protected] [webview_flutter] Support for handling basic authentication requests (flutter/packages#5727) 2024-01-31 [email protected] [tool] Extend `flutter test` workaround to other desktops (flutter/packages#6024) 2024-01-31 [email protected] [two_dimensional_scrollables] Merged cells for TableView (flutter/packages#5917) 2024-01-31 [email protected] [rfw] Restore RFW to 100% coverage after `ButtonBar` update (flutter/packages#6020) 2024-01-31 [email protected] [in_app_purchase] Convert storefront(), transactions(), canMakePayment(), and addPayment() to pigeon (flutter/packages#5910) 2024-01-31 [email protected] [in_app_purchase] Add play country code api (flutter/packages#5941) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
15 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 12, 2024
- Update the emulator versions and expose cipd. (#6025 - Enable alternitive billing only available check, add test and code to handle service unavilable in getBillingConfig - Enable alternative billing only during client creation and tests covering fallback path - ShowAlternativeBillingDialog android native method added - Add tests for null activity behavior - Remove not needed lines of code - Add showAlternativeBillingOnlyInformationDialog and isAlternativeBillingOnlyAvailable to android platform addition and billing client wrapper. - test showAlternativeBillingOnlyInformationDialog and isAlternativeBillingOnlyAvailable in platfrom addition and billing_client Fixes flutter/flutter/issues/142618 Still left TODO: * [x] incorporate new apis into example app * [x] expose alternative billing only [dart api](https://github.com/flutter/packages/pull/6056/files/d4c445422f2cd3f0627f575d85b59b559e0e9f69#r1480455450) * [x] Expose alternative billing reporting details * [ ] Configure end to end working example with playstore
16 tasks
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
Update the android virtual device to use the proto config as the version instead of the integer version. This is more robust from the recipes side as the chromium team is changing names. Expose the avd_cipd_version flag so developers can update this without touching recipes. *List which issues are fixed by this PR. You must list at least one issue.* Fixes flutter/flutter#142261 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
) - Update the emulator versions and expose cipd. (flutter#6025 - Enable alternitive billing only available check, add test and code to handle service unavilable in getBillingConfig - Enable alternative billing only during client creation and tests covering fallback path - ShowAlternativeBillingDialog android native method added - Add tests for null activity behavior - Remove not needed lines of code - Add showAlternativeBillingOnlyInformationDialog and isAlternativeBillingOnlyAvailable to android platform addition and billing client wrapper. - test showAlternativeBillingOnlyInformationDialog and isAlternativeBillingOnlyAvailable in platfrom addition and billing_client Fixes flutter/flutter/issues/142618 Still left TODO: * [x] incorporate new apis into example app * [x] expose alternative billing only [dart api](https://github.com/flutter/packages/pull/6056/files/d4c445422f2cd3f0627f575d85b59b559e0e9f69#r1480455450) * [x] Expose alternative billing reporting details * [ ] Configure end to end working example with playstore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the android virtual device to use the proto config as the version instead of the integer version. This is more robust from the recipes side as the chromium team is changing names.
Expose the avd_cipd_version flag so developers can update this without touching recipes.
List which issues are fixed by this PR. You must list at least one issue.
Fixes flutter/flutter#142261
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.