-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[webview_flutter] Support for handling basic authentication requests #5727
[webview_flutter] Support for handling basic authentication requests #5727
Conversation
…/packages into webview-auth-request
…b/src/types/http_auth_request.dart
…s into webview-auth-request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been renamed to webview_flutter_export_test.dart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc @stuartmorgan for secondary review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter/packages@5b48c44...d37fb0a 2024-02-02 [email protected] Add a link the different possible Android virtual device configs (flutter/packages#6033) 2024-02-01 [email protected] Update the emulator versions and expose cipd. (flutter/packages#6025) 2024-02-01 [email protected] [tool] Add details to missing gradle coverage error (flutter/packages#6029) 2024-02-01 [email protected] [file_selector] Fix comment typo (flutter/packages#6027) 2024-02-01 [email protected] [camerax] Change `buildPreview` to return `Texture` versus `FutureBuilder` (flutter/packages#6021) 2024-02-01 [email protected] Manual roll Flutter from c65ab4d to e02e207 (38 revisions) (flutter/packages#6028) 2024-02-01 [email protected] Manual roll Flutter from 75a2e5b to c65ab4d (22 revisions) (flutter/packages#6026) 2024-02-01 [email protected] Roll Flutter from ace9181 to 75a2e5b (16 revisions) (flutter/packages#6017) 2024-02-01 [email protected] [webview_flutter] Support for handling basic authentication requests (flutter/packages#5727) 2024-01-31 [email protected] [tool] Extend `flutter test` workaround to other desktops (flutter/packages#6024) 2024-01-31 [email protected] [two_dimensional_scrollables] Merged cells for TableView (flutter/packages#5917) 2024-01-31 [email protected] [rfw] Restore RFW to 100% coverage after `ButtonBar` update (flutter/packages#6020) 2024-01-31 [email protected] [in_app_purchase] Convert storefront(), transactions(), canMakePayment(), and addPayment() to pigeon (flutter/packages#5910) 2024-01-31 [email protected] [in_app_purchase] Add play country code api (flutter/packages#5941) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#5727) ## Description This pull request exposes the Android and iOS HTTP Basic Authentication feature to users of the `webview_flutter` plugin. It is the final PR in a sequence of PRs. Previous PRs are flutter#5362, flutter#5454 and flutter#5455. Issues fixed by PR: Closes flutter/flutter#83556
Description
This pull request exposes the Android and iOS HTTP Basic Authentication feature to users of the
webview_flutter
plugin. It is the final PR in a sequence of PRs. Previous PRs are #5362, #5454 and #5455.Issues fixed by PR:
Closes flutter/flutter#83556
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.