-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[interactive_media_ads]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.10 to 2.0.0 in /packages/interactive_media_ads/android #7036
Conversation
Bumps [org.jetbrains.kotlin:kotlin-bom](https://github.com/JetBrains/kotlin) from 1.8.10 to 2.0.0. - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.8.10...v2.0.0) --- updated-dependencies: - dependency-name: org.jetbrains.kotlin:kotlin-bom dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
2e960df
to
786c082
Compare
@flutter/android-reviewers Is there a plan to bump Kotlin versions in our plugins? It looks like the |
@gmackall has a better understanding of the kotlin relationship than I do but I am under the impression they need to move together until some specific version then they can move independently |
I think we should be able to remove these dependencies from all packages soon, actually. The main problem was that if you transitively had But now that the engine is updated, I think we should only have versions greater so we won't run in to this error. Trying out a couple of the plugins, their examples build successfully when I remove the dependency. |
Put up a pr to remove #7088;
nope, looks like it needs to wait for stable |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
~This dependency seems to no longer be necessary. I expected this would be because the the androidx upgrade that [landed recently](flutter/engine#53592) fixed the problem ([see theory](#7036 (comment))), but it seems that the packages even build on stable successfully. Perhaps there have been updates to the underlying `androidx` libraries themselves that fix the conflict, and we updated the versions in plugins far enough? I'm unsure.~ Updated for 3.24 release. In a sense, fixes flutter/flutter#125062
Bumps org.jetbrains.kotlin:kotlin-bom from 1.8.10 to 2.0.0.
Release notes
Sourced from org.jetbrains.kotlin:kotlin-bom's releases.
... (truncated)
Changelog
Sourced from org.jetbrains.kotlin:kotlin-bom's changelog.
... (truncated)
Commits
e84e835
Add changelog for 2.0.0975dea2
Add changelog for 2.0.0-RC3b618ee4
[FIR] Prohibit referencing java field in case of conflict with property..b239239
K2: build outer classes sequence in FirImplicitBodyResolve properlyafc5b49
[IR] Assume IrFile has at least one offset entrybe1804c
[K/N][tests] Don't attempt to download simulator after first failureb666160
K2: fix captureFromExpressionInternal for nullable intersection typesf04f051
K2: fix withNullability() for ConeIntersectionTypecda1ad4
K2: reproduce KT-679128e0919e
[K2/JS] Use declaration session for looking up containing declarationDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)