-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[many] Remove dependency on kotlin-bom
#7088
Conversation
Tested that the example app for each modified package builds on master still. |
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
test-exempt: configuration change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo!
#3960 suggests that we weren't catching this problem in CI. Given that, are we confident that we would catch it now (i.e., that the green result here is actually telling us what we need to know)? Can we try manually re-creating (on stable) some things like what's described in that PR description? |
This is a good question, I'll try with a workflow similar to what I described in that PR for all the affected packages on stable. If I had to guess why we didn't catch this in ci for |
Hmm okay, yeah the workflow described in the PR:
Fails on stable, while succeeding on master. So this will indeed have to wait for the next stable. I'll also try to figure out why the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve % next stable being set at the minimum
This should be ready for review again for any remaining reviewers that want to take a look. |
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter/packages@4e5d47e...c5d03ee 2024-08-21 [email protected] [many] Remove dependency on `kotlin-bom` (flutter/packages#7088) 2024-08-21 [email protected] Remove unnecessary breaks in default clauses of switch statements (flutter/packages#7462) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@4e5d47e...c5d03ee 2024-08-21 [email protected] [many] Remove dependency on `kotlin-bom` (flutter/packages#7088) 2024-08-21 [email protected] Remove unnecessary breaks in default clauses of switch statements (flutter/packages#7462) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Our assumptions about this being safe might not be correct https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20android_platform_tests_shard_2%20master/1640/overview |
#7997 has some follow-up analysis on that failure. |
#7986 Updated the annotation version FWIW flutter fix said to update the kotlin version to 1.9. |
This dependency seems to no longer be necessary. I expected this would be because the the androidx upgrade that landed recently fixed the problem (see theory), but it seems that the packages even build on stable successfully. Perhaps there have been updates to the underlyingandroidx
libraries themselves that fix the conflict, and we updated the versions in plugins far enough? I'm unsure.Updated for 3.24 release.
In a sense, fixes flutter/flutter#125062
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.