[go_router] add current state getter #7651
Merged
+92
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedvdb
changed the title
cedvdb
changed the title
cedvdb
commented
Sep 16, 2024
chunhtai
reviewed
Sep 18, 2024
There was a problem hiding this comment.
This can also solve flutter/flutter#129833
Edit: nvm you already linked the issue
|
@hangyujin requesting the additional necessary review |
chunhtai
approved these changes
Oct 4, 2024
chunhtai
added
the
autosubmit
|
auto label is removed for flutter/packages/7651, due to - The status or check suite Linux_android android_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 5, 2024
flutter/packages@796afa3...7219431 2024-11-05 [email protected] [vector_graphics*] Relax dependency constraints of vector_graphics, vector_graphics_codec, vector_graphics_compiler, flutter_svg (flutter/packages#8018) 2024-11-04 [email protected] [various] Add `missing_code_block_language_in_doc_comment` lint to flutter/packages. (flutter/packages#6473) 2024-11-04 [email protected] [various] Update example apps to Kotlin 1.9.0 (flutter/packages#7998) 2024-11-04 [email protected] [go_router] add current state getter (flutter/packages#7651) 2024-11-04 [email protected] Applied Gradle Plugins Declaratively for Multiple Plugin Example Apps (flutter/packages#7968) 2024-11-04 [email protected] Roll Flutter from f86b777 to 8591d0c (16 revisions) (flutter/packages#8015) 2024-11-04 [email protected] [camera_windows] Revert: Support image streams on Windows platform (flutter/packages#7951) 2024-11-02 [email protected] [camera] Use Pigeon for Windows C++->Dart (flutter/packages#8001) 2024-11-02 [email protected] [script/tool] update dependencies (flutter/packages#7992) 2024-11-01 [email protected] Roll Flutter from 0fe6153 to f86b777 (16 revisions) (flutter/packages#8000) 2024-11-01 [email protected] [path_parsing] deprecate utility functions that should be private (flutter/packages#7993) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a current state getter that returns
GoRouterState.I've no idea if this is correct but the added tests seem to be passing. Rebuilding the state may be expensive too ?
Fix: flutter/flutter#129833
fixes flutter/flutter#148215
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.