[various] Update example apps to Kotlin 1.9.0 #7998
Conversation
Follow-up to flutter#7997 to update all example apps to 1.9.0 to protect us from similar OOB failures as other transitive dependencies in the ecosystem update to newer versions of Kotlin.
stuartmorgan
requested review from
reidbaker,
gmackall,
camsim99,
domesticmouse,
Piinks,
tarrinneal,
Hixie,
gspencergoog and
goderbauer
as code owners
github-actions
bot
added
p: pigeon
p: flutter_markdown
p: flutter_image
p: rfw
|
@gmackall / @reidbaker My reasoning here is that now that we have a Flutter Fix telling people what to do in cases like #7997, and that we deliberately removed the workaround that was intended to prevent it in #7088, we consider that kind of failure something clients should fix in their app (per the Flutter Fix) rather than a bug in our plugins. If that's the case, it's better to preemptively update our example apps to avoid hitting it as an OOB failure. If those assumptions aren't correct (and, e.g., we want to revert that |
There was a problem hiding this comment.
@gmackall / @reidbaker My reasoning here is that now that we have a Flutter Fix telling people what to do in cases like #7997, and that we deliberately removed the workaround that was intended to prevent it in #7088, we consider that kind of failure something clients should fix in their app (per the Flutter Fix) rather than a bug in our plugins. If that's the case, it's better to preemptively update our example apps to avoid hitting it as an OOB failure.
I think it makes sense to have users update now that we have an error handler in place, lgtm.
stuartmorgan
added
the
autosubmit
|
auto label is removed for flutter/packages/7998, due to Pull request flutter/packages/7998 is not in a mergeable state. |
auto-submit
bot
removed
the
autosubmit
stuartmorgan
force-pushed
the
android-examples-kotlin-1-9
branch
from
d2e0d4c
to
16ea5d9
Compare
stuartmorgan
added
the
autosubmit
flutter/packages@796afa3...7219431 2024-11-05 [email protected] [vector_graphics*] Relax dependency constraints of vector_graphics, vector_graphics_codec, vector_graphics_compiler, flutter_svg (flutter/packages#8018) 2024-11-04 [email protected] [various] Add `missing_code_block_language_in_doc_comment` lint to flutter/packages. (flutter/packages#6473) 2024-11-04 [email protected] [various] Update example apps to Kotlin 1.9.0 (flutter/packages#7998) 2024-11-04 [email protected] [go_router] add current state getter (flutter/packages#7651) 2024-11-04 [email protected] Applied Gradle Plugins Declaratively for Multiple Plugin Example Apps (flutter/packages#7968) 2024-11-04 [email protected] Roll Flutter from f86b777 to 8591d0c (16 revisions) (flutter/packages#8015) 2024-11-04 [email protected] [camera_windows] Revert: Support image streams on Windows platform (flutter/packages#7951) 2024-11-02 [email protected] [camera] Use Pigeon for Windows C++->Dart (flutter/packages#8001) 2024-11-02 [email protected] [script/tool] update dependencies (flutter/packages#7992) 2024-11-01 [email protected] Roll Flutter from 0fe6153 to f86b777 (16 revisions) (flutter/packages#8000) 2024-11-01 [email protected] [path_parsing] deprecate utility functions that should be private (flutter/packages#7993) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Follow-up to #7997 to update all example apps to 1.9.0 to protect us from similar OOB failures as other transitive dependencies in the ecosystem update to newer versions of Kotlin.