[camerax] Correct assumption about preview being correctly rotated by default on API 29 #7714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...roid_camerax/android/src/main/java/io/flutter/plugins/camerax/SystemServicesHostApiImpl.java
Outdated
Show resolved
Hide resolved
...roid_camerax/android/src/main/java/io/flutter/plugins/camerax/SystemServicesHostApiImpl.java
Outdated
Show resolved
Hide resolved
...era_android_camerax/android/src/test/java/io/flutter/plugins/camerax/SystemServicesTest.java
Outdated
Show resolved
Hide resolved
|
Tested this fix on Android (Huawei Y70, Samsung S22 ultra and Samsung S23+) -> Can confirm that this does in fact fix the orientation on Android. Overrode the dependency, with these changes to determine before and after. 🔥 |
…o/flutter/plugins/camerax/SystemServicesHostApiImpl.java Co-authored-by: Navaron Bracke <[email protected]>
…o/flutter/plugins/camerax/SystemServicesHostApiImpl.java Co-authored-by: Navaron Bracke <[email protected]>
reidbaker
reviewed
Sep 30, 2024
...era_android_camerax/android/src/test/java/io/flutter/plugins/camerax/SystemServicesTest.java
Outdated
Show resolved
Hide resolved
…o/flutter/plugins/camerax/SystemServicesTest.java
reidbaker
requested changes
Sep 30, 2024
packages/camera/camera_android_camerax/lib/src/android_camera_camerax.dart
Outdated
Show resolved
Hide resolved
reidbaker
approved these changes
Oct 1, 2024
camsim99
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 1, 2024
…tated by default on API 29 (flutter/packages#7714)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 1, 2024
flutter/packages@27c9853...ebcc4f0 2024-10-01 [email protected] [camerax] Correct assumption about preview being correctly rotated by default on API 29 (flutter/packages#7714) 2024-09-30 [email protected] Replace `initialPage` parameter with `benchmarkPath` (flutter/packages#7743) 2024-09-30 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.webkit:webkit from 1.11.0 to 1.12.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#7681) 2024-09-30 49699333+dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump com.google.ads.interactivemedia.v3:interactivemedia from 3.35.0 to 3.35.1 in /packages/interactive_media_ads/android (flutter/packages#7734) 2024-09-30 [email protected] [interactive_media_ads] Change the location of where the AdsLoader is initialized (flutter/packages#7721) 2024-09-30 [email protected] [file_selector] Update Windows Pigeon for non-nullable generics (flutter/packages#7730) 2024-09-30 [email protected] [interactive_media_ads] Adds internal wrapper for Android native `AdProgressInfo` (flutter/packages#7723) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes assumption about camera preview being automatically corrected by CameraX on API <= 29 to API < 29 based on the fact that an
ImageReaderbacks devices running API 29+, on which the camera preview will not automatically be corrected by CameraX.Related to flutter/flutter#154241.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).