Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web_benchmarks] Replace initialPage parameter with benchmarkPath #7743

Merged
merged 24 commits into from
Sep 30, 2024

Conversation

kenzieschmoll
Copy link
Member

@kenzieschmoll kenzieschmoll commented Sep 30, 2024

This will unblock flutter/devtools#8320. This is a follow up to the initial attempt here: #7632

Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenzieschmoll kenzieschmoll added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 30, 2024
@auto-submit auto-submit bot merged commit 33fa73a into flutter:main Sep 30, 2024
76 checks passed
@kenzieschmoll kenzieschmoll deleted the benchmarkPath branch October 1, 2024 01:40
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 1, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 1, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 1, 2024
flutter/packages@27c9853...ebcc4f0

2024-10-01 [email protected] [camerax] Correct assumption about preview being correctly rotated by default on API 29 (flutter/packages#7714)
2024-09-30 [email protected] Replace `initialPage` parameter with `benchmarkPath` (flutter/packages#7743)
2024-09-30 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.webkit:webkit from 1.11.0 to 1.12.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#7681)
2024-09-30 49699333+dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump com.google.ads.interactivemedia.v3:interactivemedia from 3.35.0 to 3.35.1 in /packages/interactive_media_ads/android (flutter/packages#7734)
2024-09-30 [email protected] [interactive_media_ads] Change the location of where the AdsLoader is initialized (flutter/packages#7721)
2024-09-30 [email protected] [file_selector] Update Windows Pigeon for non-nullable generics (flutter/packages#7730)
2024-09-30 [email protected] [interactive_media_ads] Adds internal wrapper for Android native `AdProgressInfo` (flutter/packages#7723)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@kenzieschmoll kenzieschmoll changed the title Replace initialPage parameter with benchmarkPath [web_benchmarks] Replace initialPage parameter with benchmarkPath Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: web_benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants